This is the mail archive of the
mailing list for the binutils project.
Re: binutils 220.127.116.11.46: IEEE support is broken in binutils because of `slashpatch'
- To: AAganichev at hypercom dot com
- Subject: Re: binutils 18.104.22.168.46: IEEE support is broken in binutils because of `slashpatch'
- From: Eli Zaretskii <eliz at delorie dot com>
- Date: Wed, 21 Jun 2000 01:27:58 -0400 (EDT)
- CC: nickc at cygnus dot com, bug-gnu-utils at gnu dot org, binutils at sourceware dot cygnus dot com
- References: <OF8B9D63D5.B8E2978E-ONC3256904.0020967A@hypercom.com>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> From: "Alexander Aganichev" <AAganichev@hypercom.com>
> Date: Tue, 20 Jun 2000 10:03:05 +0100
> I've made the changes you suggested and attach the patch to this message.
> (See attached file: dosslash.fix.diff)
> - filename = file + 1;
> + filename = file + 2;
> - temp = program_name + 1;
> + temp = program_name + 2;
I think the above two changes in ar.c (and a similar change in
bucomm.c) are wrong: this code is handling the case of "d:foo", where
there's no slash or backslash in the file name, but there is a drive
letter. In this case, the basename begins right after the colon.
However, the code later on increments `filename' and `temp', like
if (filename != (char *) NULL)
filename = file;
Therefore, we should set `filename' to point to the colon, not to the
character after it.