Re: [patch]: ld version script grammar failures

["H . J . Lu" <hjl at lucon dot org>]

On Mon, Jun 05, 2000 at 08:28:37AM +0100, Philip Blundell wrote:
> In message <telnet.0006050248160.12875-100000@juno.ifh.de>, Michael Matz writes
> :
> >near. Good :) As I pointed out some weeks ago, ld has problems with the
> >C++ symbols support in version scripts. In the branch, and in HEAD. It
> >segfaults for version scripts containing 'extern "C++" { bla }'
> >directives. This is due to a wrong yacc rule (patch for ldgram.y).
> >
> >And it doesn't recognize '::' in those C++ symbols, due to too restrictive
> >LEX symbols definitions (second patch for ldlex.l). 
> 
> Your patch looks OK to me.  If it is approved for the trunk it can go into the 
> branch as well.  (Next time, please supply a ChangeLog entry too.)
> 

I checked it into trunk with ChangeLog entry:

2000-06-05  Michael Matz <matz@ifh.de>

        * ldgram.y (vers_defns): Handle 'extern "C++" { ... }' in
         version scripts.

         * ldlex.l (V_IDENTIFIER): Accept `::' in symbols.

Let me know if it breaks anything.

Thanks.


H.J.