This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
A bad change to gas
- To: alan at linuxcare dot com dot au
- Subject: A bad change to gas
- From: "H . J . Lu" <hjl at valinux dot com>
- Date: Sat, 3 Jun 2000 15:40:10 -0700
- Cc: binutils at sourceware dot cygnus dot com
Hi, Alan,
I checked in the patch enclosed here to fix the bug introduced by:
2000-06-01 Alan Modra <alan@linuxcare.com.au>
* read.c (is_end_of_line): Use 1 instead of 99. Don't set `;'
entry (or `!' entry for TC_HPPA).
The problem is `;' was the line separator by default. Many CPUs,
including ia32, doesn't have `;' in line_separator_chars. Your change
just breaks all those CPUs :-).
BTW, I found it out by compiling Linux kernel. I guess glibc may also
use `;' in asm statements.
--
H.J. Lu (hjl@gnu.org)
---
2000-06-03 H.J. Lu <hjl@gnu.org>
* read.c (is_end_of_line): Put back `;'.
Index: read.c
===================================================================
RCS file: /work/cvs/gnu/binutils/gas/read.c,v
retrieving revision 1.15
diff -u -p -r1.15 read.c
--- read.c 2000/06/02 23:36:51 1.15
+++ read.c 2000/06/03 22:24:53
@@ -155,7 +155,7 @@ char is_end_of_line[256] =
#endif
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* */
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* _!"#$%&'()*+,-./ */
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 0123456789:;<=>? */
+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, /* 0123456789:;<=>? */
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* */
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* */
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* */