This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

RE: bfd/peigen.c problems and fix



On Mon, 8 May 2000, Donn Terry wrote:

> I'm still not to the point of being able to dig thru all
> of what's going on with this, but the patch made to peigen.c
> (1.9) doesn't seem right to me.

Maybe it doesn't *seem* right to you but now it *works* for me for every
dll's and exe's that I tested.
 
> Primarily, it removes a lot of code that doesn't have anything
> to do with the problem of Image Base.  In fact it removes code
> that allows it to dump DLLs that it otherwise could not dump.

The above statment correctly, 
In fact it removes code that *disallows* it to dump DLLs that it otherwise
*could* dump.

Before it was pretty annoying to watch the "There is an import table, but
the section containing it could not be found" messages, what I remember
you added but I don't have the picture what the reason was to break PEI so
badly.

> The change to insert or delete ImageBase (until the base problem
> gets fixed) is reasonable, but the other stuff should be left
> in place.

Yes, if you want a non-functioning objdump in the future as well. Please
send me testcases that don't work since I can't found [sure I don't
have sample from all of the PEI variants]. Thanks.

	Szaka


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]