This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: coff-ia64 doesn't build
>>>>> Ian Lance Taylor writes:
Ian> From: Andreas Jaeger <aj@suse.de>
Ian> Date: 28 Apr 2000 17:23:44 +0200
Ian> Building binutils with:
Ian> configure --prefix=/opt/binutils --enable-shared \
Ian> --disable-nls \
Ian> --enable-build-warnings --enable-targets=all --enable-64-bit-bfd
Ian> on i686-linux, I get:
Ian> /cvs/binutils/bfd/coff-ia64.c:40: warning: missing initializer
Ian> /cvs/binutils/bfd/coff-ia64.c:40: warning: (near initialization for `howto_table[0].rightshift')
Ian> In file included from /cvs/binutils/bfd/coffcode.h:310,
Ian> from /cvs/binutils/bfd/coff-ia64.c:68:
Ian> /cvs/binutils/bfd/coffswap.h: In function `coff_swap_aouthdr_in':
Ian> /cvs/binutils/bfd/coffswap.h:662: structure has no member named `data_start'
Ian> /cvs/binutils/bfd/coffswap.h: In function `coff_swap_aouthdr_out':
Ian> /cvs/binutils/bfd/coffswap.h:737: structure has no member named `data_start'
Ian> make[3]: *** [coff-ia64.lo] Error 1
Ian> Shouldn't this be an EMPTY_HOWTO (0) in line 40?
Ian> Yes.
Ok, I'm appending a patch. Could somebody please check this in? I
don't have write-access for binutils.
Ian> What's the right way
Ian> to handle data_start in coffswap.h?
Ian> Why doesn't it work? data_start is a field in internal_aouthdr in
Ian> include/coff/internal.h.
include/coff/ia64.h has:
#ifndef BFD64
char data_start[4]; /* base of data used for this file */
#endif
}
AOUTHDR;
and BFD64 is defined (I configured with --enable-targets=all
--enable-64-bit-bfd).
I don't know if removing the #ifndef is the right thing to do (it
seems to be - at least I manage to compile the files then). Could one
of the ia64 binutils maintainers check this, please? I'm appending
a patch for this below.
Andreas
For bfd:
2000-04-29 Andreas Jaeger <aj@suse.de>
* coff-ia64.c (howto_table): Use EMPTY_HOWTO to properly
initialize table.
Index: bfd/coff-ia64.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-ia64.c,v
retrieving revision 1.1
diff -u -r1.1 coff-ia64.c
--- coff-ia64.c 2000/04/18 04:03:16 1.1
+++ coff-ia64.c 2000/04/29 11:31:42
@@ -1,5 +1,5 @@
/* BFD back-end for HP/Intel IA-64 COFF files.
- Copyright 1999 Free Software Foundation, Inc.
+ Copyright 1999, 2000 Free Software Foundation, Inc.
Contributed by David Mosberger <davidm@hpl.hp.com>
This file is part of BFD, the Binary File Descriptor library.
@@ -37,7 +37,7 @@
static reloc_howto_type howto_table[] =
{
- {0},
+ EMPTY_HOWTO (0),
};
#define BADMAG(x) IA64BADMAG(x)
For include/coff:
2000-04-29 Andreas Jaeger <aj@suse.de>
* ia64.h (AOUTHDR): Remove #ifndef BFD64.
Index: include/coff/ia64.h
===================================================================
RCS file: /cvs/src/src/include/coff/ia64.h,v
retrieving revision 1.1
diff -u -r1.1 ia64.h
--- ia64.h 2000/04/17 23:45:22 1.1
+++ ia64.h 2000/04/29 11:44:34
@@ -47,9 +47,7 @@
char bsize[4]; /* uninitialized data " " */
char entry[4]; /* entry pt. */
char text_start[4]; /* base of text used for this file */
-#ifndef BFD64
char data_start[4]; /* base of data used for this file */
-#endif
}
AOUTHDR;
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.rhein-neckar.de