This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] Fix warnings for d10v-elf


Nick Clifton wrote:
> 
> Hi Andrew,
> 
> : > :       * config/tc-d10v.c (d10v_fix_adjustable, md_pcrel_from_section):
> : > :       Change type of `fixS' argument to `struct fix'.
> : >
> : > Why is this necessary ?  'fixS' is a typedef of 'struct fix'.
> :
> : I tried that and got:
> :
> : In file included from targ-cpu.h:1,
> :                  from /home/scratch/SRC/src/gas/config/obj-elf.h:40,
> :                  from obj-format.h:1,
> :                  from /home/scratch/SRC/src/gas/config/te-generic.h:19,
> :                  from targ-env.h:1,
> :                  from /home/scratch/SRC/src/gas/as.h:616,
> :                  from /home/scratch/SRC/src/gas/app.c:29:
> : /home/scratch/SRC/src/gas/config/tc-d10v.h:60: parse error before `*'
> :
> : There is a ``struct fix;'' in as.h.
> 
> That is very strange.  I tried checking out and building GAS for the
> d10v using the current sources (without your patch applied) and it
> built just fine.  In particular this problem should not arise because
> in gas/write.h there is the line:

Hmm, maybe I answered the wrong question.  Were you asking about my
fixS->``struct fix'' as a general question or specificly for the
function definition in tc-d10v.c?

The declaration needs ``struct fix''.  I changed the definition to match
the declaration for consistency.

	enjoy,
		Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]