Re: [RFA] Fix warnings for d10v-elf

[Nick Clifton <nickc at cygnus dot com>]

Hi Andrew,

: > :       * config/tc-d10v.c (d10v_fix_adjustable, md_pcrel_from_section):
: > :       Change type of `fixS' argument to `struct fix'.
: > 
: > Why is this necessary ?  'fixS' is a typedef of 'struct fix'.
: 
: I tried that and got:
: 
: In file included from targ-cpu.h:1,
:                  from /home/scratch/SRC/src/gas/config/obj-elf.h:40,
:                  from obj-format.h:1,
:                  from /home/scratch/SRC/src/gas/config/te-generic.h:19,
:                  from targ-env.h:1,
:                  from /home/scratch/SRC/src/gas/as.h:616,
:                  from /home/scratch/SRC/src/gas/app.c:29:
: /home/scratch/SRC/src/gas/config/tc-d10v.h:60: parse error before `*'
: 
: There is a ``struct fix;'' in as.h.

That is very strange.  I tried checking out and building GAS for the
d10v using the current sources (without your patch applied) and it
built just fine.  In particular this problem should not arise because
in gas/write.h there is the line: 

  typedef struct fix fixS;

Besides according to that error description above the problem is not
with compiling tc-d10v.c but with compiling app.c, which appears to be 
including tc-d10v.h without including write.h.

I think that your sources may be out of date.  For example there is no
asterisk anywhere on line 60 of tc-d10v.h.  Please could you check to
see that your are fixing a bug against the latest sourceware sources?

Cheers
	Nick