This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[patch] m32r gas relocation processing


Catherine Moore writes:
 > I would like to propose the following patch which fixes a problem in
 > gas/cgen.c.  This problem shows up in the m32r port and can be
 > demonstrated with the following test case:

This is the same testcase dlindsay submitted earlier to this list, right?

 > This problem would probably show up in any port that uses gas/cgen.c
 > and REL type relocations.  I don't know if there is an accepted way
 > to determine that a particular port uses REL relocations in the
 > generic portion of gas.  This patch does this extra processing only
 > if TC_M32R is defined.  I am open to suggestions for coding this in
 > a more target-independent fashion.
 > 
 > The relocation processing for the m32r was based on the mips port.
 > This patch was modified from similar processing that is done for mips.
 > Okay to install?

If it's my call, I'd say let's spend some more time trying to come up
with a proper fix.
[as you say #ifdef TC_M32R in a target independent file is a no-no.]

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]