This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: Patch: fix shell lossage in BFD_HAVE_SYS_PROCFS_TYPE_MEMBER
- To: "Philippe De Muyter" <phdm at macqel dot be>
- Subject: Re: Patch: fix shell lossage in BFD_HAVE_SYS_PROCFS_TYPE_MEMBER
- From: Jim Blandy <jimb at zwingli dot cygnus dot com>
- Date: 09 Mar 2000 13:40:30 -0500
- Cc: binutils at sourceware dot cygnus dot com
- References: <200003021603.RAA14293@mail.macqel.be>
"Philippe De Muyter" <phdm@macqel.be> writes:
> > > > > 2000-02-09 Jim Blandy <jimb@redhat.com>
> > > > >
> > > > > * acinclude.m4 (BFD_HAVE_SYS_PROCFS_TYPE_MEMBER): Don't forget to
> > > > > put quotes around the cache variable referenc when passing it to
> > > > > `test', so it'll always expand into an argument.
> > > >
> > > > This patch does no harm, so it is OK with me, but I don't understand
> > > > why it is necessary. If this patch is necessary, there are a number
> > > > of other places where a cache variable is tested without using quotes.
> > > > The autoconf macros should always arrange for a cache variable to have
> > > > a non-empty value; why is that not happening for you?
> > >
> > > I don't know. I'll figure it out, and get back to you.
> >
> > I can't reproduce this any more, so I withdraw this patch.
> >
>
> Did it happen because you had a cache file, but not containing this particular
> variable, because either it was a new one (introduced by a new test in
> configure) or either the cache file was shared by many configure-files,
> and the first configure does not initialize this particular variable ?
>
> If that can happen, I would not withdraw your patch.
I think that shouldn't make a difference. In that case, the variable
should be unset, and thus the code emitted by AC_CACHE_VAL should
detect this and recompute its value:
echo $ac_n "checking for prstatus_t in sys/procfs.h""... $ac_c" 1>&6
echo "configure:4658: checking for prstatus_t in sys/procfs.h" >&5
if eval "test \"`echo '$''{'bfd_cv_have_sys_procfs_type_prstatus_t'+set}'`\" = set"; then
echo $ac_n "(cached) $ac_c" 1>&6
else
...