This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH]: Turn on all for Linux/ia32


   Date: Thu, 2 Mar 2000 10:03:07 -0800
   From: "H . J . Lu" <hjl@valinux.com>

   I'd like to check in this patch for gas. It seems to work on
   Linux/ia32, Solaris/ia32 and Solaris/Sparc.

   Wed Feb  2 09:49:57 2000  H.J. Lu  (hjl@gnu.org)

	   * configure.in: Support --enable-targets=all and enable
	   i386aout and i386coff for Linux when --enable-targets=all
	   is used.
	   * configure: Regenerated.

I think this needs more work.  I don't mind in principle supporting
--enable-targets=all for gas, although I'm concerned that it is
misleading since it does not actually support all targets.

Your patch will run the `all' case through the whole target switch.
That doesn't make sense given the way it is written and the different
cases it goes through.  I think it only works because the shell
variables happen to have been set in the earlier loop iteration.

I think it would be cleaner to handle the `all' case separately.
Right now it is nearly meaningless, but perhaps it can become more
meaningful over time.  I don't think putting `all' in canon_targets is
really the right approach for the assembler.

Ian

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]