This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: Patch to get rid of warnings when building on ARM...
- To: scottb at netwinder dot org
- Subject: Re: Patch to get rid of warnings when building on ARM...
- From: Nick Clifton <nickc at cygnus dot com>
- Date: Wed, 27 Oct 1999 19:05:30 +0100
- CC: binutils at sourceware dot cygnus dot com
- Reply-to: nickc at cygnus dot co dot uk
Hi Scott,
: I was cross compiling binutils and decided to examine all the warnings.
: Tne attached patch gets rid of all warnings except those for
: signed-unsigned comparisons and unused parameters.
Thanks for the patch. Could you include ChangeLog entries next time
as well ?
: Well not quite. There is still one left in gas/write.c. In
: write_object_file(), the variable punt is passed to elf_frob_symbol()
: and tc_frob_symbol(). I believe they should be passed the address of
: punt. Comments?
Not quite. The obj_frob_symbol() macro should take the address of
punt. See similar definitions in config/obj-elf.h and
config/obj-coff.h. I have made this change to your patch and checked
the results in.
Cheers
Nick