This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb/binutils-2_32-branch] Assorted warning fixes
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 31 Jan 2019 04:21:58 -0000
- Subject: [binutils-gdb/binutils-2_32-branch] Assorted warning fixes
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d3357b4a6f1201b9675791b1731ed2a08fcd3070
commit d3357b4a6f1201b9675791b1731ed2a08fcd3070
Author: Alan Modra <amodra@gmail.com>
Date: Thu Jan 31 14:38:45 2019 +1030
Assorted warning fixes
gcc-9 flagged warnings at the places I'm patching here, all real bugs.
* config/tc-alpha.c (md_apply_fix): Correct range checks for
BFD_RELOC_ALPHA_NOP, BFD_RELOC_ALPHA_LDA, BFD_RELOC_ALPHA_BSR.
* config/tc-arm.c (md_apply_fix): Use llabs rather than abs.
* config/tc-csky.c (get_macro_reg_vals): Pass s to csky_show_error.
(cherry picked from commit 3ca4a8eca78b4d5e3fa308dbd21c67ebef09a261)
Diff:
---
gas/ChangeLog | 7 +++++++
gas/config/tc-alpha.c | 6 +++---
gas/config/tc-arm.c | 8 ++++----
gas/config/tc-csky.c | 2 +-
4 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 58cc787..1ab4619 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,10 @@
+2019-01-31 Alan Modra <amodra@gmail.com>
+
+ * config/tc-alpha.c (md_apply_fix): Correct range checks for
+ BFD_RELOC_ALPHA_NOP, BFD_RELOC_ALPHA_LDA, BFD_RELOC_ALPHA_BSR.
+ * config/tc-arm.c (md_apply_fix): Use llabs rather than abs.
+ * config/tc-csky.c (get_macro_reg_vals): Pass s to csky_show_error.
+
2019-01-29 Max Filippov <jcmvbkbc@gmail.com>
* config/tc-xtensa.c (md_apply_fix): Mark fixups for constant
diff --git a/gas/config/tc-alpha.c b/gas/config/tc-alpha.c
index 606f201..7f80036 100644
--- a/gas/config/tc-alpha.c
+++ b/gas/config/tc-alpha.c
@@ -5878,7 +5878,7 @@ md_apply_fix (fixS *fixP, valueT * valP, segT seg)
return;
}
- if ((abs (value) >> 2) & ~0xfffff)
+ if (value + (1u << 22) >= (1u << 23))
goto done;
else
{
@@ -5897,7 +5897,7 @@ md_apply_fix (fixS *fixP, valueT * valP, segT seg)
return;
}
- if ((abs (value)) & ~0x7fff)
+ if (value + (1u << 15) >= (1u << 16))
goto done;
else
{
@@ -5917,7 +5917,7 @@ md_apply_fix (fixS *fixP, valueT * valP, segT seg)
return;
}
- if ((abs (value) >> 2) & ~0xfffff)
+ if (value + (1u << 22) >= (1u << 23))
{
/* Out of range. */
if (fixP->fx_r_type == BFD_RELOC_ALPHA_BOH)
diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index da5dd25..81b5cee 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -24507,7 +24507,7 @@ md_apply_fix (fixS * fixP,
{
bfd_vma insn;
bfd_vma encoded_addend;
- bfd_vma addend_abs = abs (value);
+ bfd_vma addend_abs = llabs (value);
/* Check that the absolute value of the addend can be
expressed as an 8-bit constant plus a rotation. */
@@ -24548,7 +24548,7 @@ md_apply_fix (fixS * fixP,
if (!seg->use_rela_p)
{
bfd_vma insn;
- bfd_vma addend_abs = abs (value);
+ bfd_vma addend_abs = llabs (value);
/* Check that the absolute value of the addend can be
encoded in 12 bits. */
@@ -24587,7 +24587,7 @@ md_apply_fix (fixS * fixP,
if (!seg->use_rela_p)
{
bfd_vma insn;
- bfd_vma addend_abs = abs (value);
+ bfd_vma addend_abs = llabs (value);
/* Check that the absolute value of the addend can be
encoded in 8 bits. */
@@ -24627,7 +24627,7 @@ md_apply_fix (fixS * fixP,
if (!seg->use_rela_p)
{
bfd_vma insn;
- bfd_vma addend_abs = abs (value);
+ bfd_vma addend_abs = llabs (value);
/* Check that the absolute value of the addend is a multiple of
four and, when divided by four, fits in 8 bits. */
diff --git a/gas/config/tc-csky.c b/gas/config/tc-csky.c
index 550de10..75ced2a 100644
--- a/gas/config/tc-csky.c
+++ b/gas/config/tc-csky.c
@@ -5494,7 +5494,7 @@ get_macro_reg_vals (int *reg1, int *reg2, int *reg3)
s += nlen;
if (*s != '\0')
{
- csky_show_error (ERROR_BAD_END, 0, NULL, NULL);
+ csky_show_error (ERROR_BAD_END, 0, s, NULL);
return FALSE;
}
if (*reg1 == -1 || *reg2 == -1 || *reg3 == -1)