This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] RS6000/BFD: Remove dead duplicate `config.bfd' target matchers


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ed3162adc45291b3de496be25911ebfd39f43a36

commit ed3162adc45291b3de496be25911ebfd39f43a36
Author: Maciej W. Rozycki <macro@linux-mips.org>
Date:   Thu Sep 20 15:49:00 2018 +0100

    RS6000/BFD: Remove dead duplicate `config.bfd' target matchers
    
    Remove duplicate `rs6000-*-aix5.[01]' and `rs6000-*-aix[5-9]*' target
    configuration selectors meant to correspond to `powerpc64-*-aix5.[01]'
    and `powerpc64-*-aix[5-9]*' respectively for the purpose of BFD target
    vector selection in `config.bfd'.
    
    These selectors were added with commit 9a9e2ca33263 ("rs6000 xcoff bfd
    config"), <https://sourceware.org/ml/binutils/2010-12/msg00372.html>,
    and have been dead right from the beginning, because they appear twice
    each in the case statement, which means the earlier instance of each
    takes precedence and the other one is ignored.  Here ones that alias to
    `powerpc-*-aix5.[01]' and `powerpc-*-aix[5-9]*' respectively immediately
    above are used instead.
    
    	bfd/
    	* config.bfd <rs6000-*-aix5.[01], rs6000-*-aix[5-9]*>: Remove
    	duplicate `case' selectors.

Diff:
---
 bfd/ChangeLog  | 5 +++++
 bfd/config.bfd | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 2b688ca..cfd89cb 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2018-09-20  Maciej W. Rozycki  <macro@linux-mips.org>
+
+    	* config.bfd <rs6000-*-aix5.[01], rs6000-*-aix[5-9]*>: Remove
+    	duplicate `case' selectors.
+
 2018-09-20  Nelson Chu <nelson.chu1990@gmail.com>
 
 	* elf32-nds32.c (nds32_elf_relax_loadstore):
diff --git a/bfd/config.bfd b/bfd/config.bfd
index 0e397f5..5d8424a 100644
--- a/bfd/config.bfd
+++ b/bfd/config.bfd
@@ -1066,7 +1066,7 @@ case "${targ}" in
     want64=true
     ;;
 #ifdef BFD64
-  powerpc64-*-aix5.[01] | rs6000-*-aix5.[01])
+  powerpc64-*-aix5.[01])
     targ_defvec=rs6000_xcoff64_aix_vec
     targ_selvecs="rs6000_xcoff_vec"
     want64=true
@@ -1079,7 +1079,7 @@ case "${targ}" in
     want64=true
     ;;
 #ifdef BFD64
-  powerpc64-*-aix[5-9]* | rs6000-*-aix[5-9]*)
+  powerpc64-*-aix[5-9]*)
     targ_cflags=-DAIX_WEAK_SUPPORT
     targ_defvec=rs6000_xcoff64_aix_vec
     targ_selvecs="rs6000_xcoff_vec"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]