This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] [ARM] Fix warning cannot find thumb start symbol
- From: Christophe Lyon <clyon at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 9 Jul 2018 07:48:47 -0000
- Subject: [binutils-gdb] [ARM] Fix warning cannot find thumb start symbol
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f5a1cdde80a5cc5f1b86be7e94fb062d3fd4aca9
commit f5a1cdde80a5cc5f1b86be7e94fb062d3fd4aca9
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date: Mon Jul 9 07:45:46 2018 +0000
[ARM] Fix warning cannot find thumb start symbol
In case params.thumb_entry_symbol has its default NULL value, using it
to print a warning in gld${EMULATION_NAME}_finish results in a crash.
Use h->root.string instead which either points to
params.thumb_entry_symbol name or to entry_symbol name.
2018-07-09 Christophe Lyon <christophe.lyon@linaro.org>
* emultempl/armelf.em (gld${EMULATION_NAME}_finish): Use the right
symbol name in case of warning.
Change-Id: Iec61a833c0ad538b1440bf326ba67834c314dd63
Diff:
---
ld/ChangeLog | 5 +++++
ld/emultempl/armelf.em | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index b9bfc2b..2d748f1 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-09 Christophe Lyon <christophe.lyon@linaro.org>
+
+ * emultempl/armelf.em (gld${EMULATION_NAME}_finish): Use the right
+ symbol name in case of warning.
+
2018-07-05 Jim Wilson <jimw@sifive.com>
* configure.tgt (riscv-*-*): Add as an alias for riscv32*-*-*.
diff --git a/ld/emultempl/armelf.em b/ld/emultempl/armelf.em
index 2d98064..8ceceda 100644
--- a/ld/emultempl/armelf.em
+++ b/ld/emultempl/armelf.em
@@ -499,7 +499,7 @@ gld${EMULATION_NAME}_finish (void)
}
else
einfo (_("%P: warning: cannot find thumb start symbol %s\n"),
- params.thumb_entry_symbol);
+ h->root.string);
}
/* This is a convenient point to tell BFD about target specific flags.