This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] objcopy memory leak


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=be74fad95edc8827516e144cf38d135b503249cd

commit be74fad95edc8827516e144cf38d135b503249cd
Author: Alan Modra <amodra@gmail.com>
Date:   Wed Nov 15 22:23:22 2017 +1030

    objcopy memory leak
    
    	PR 22426
    	* objcopy.c (copy_main): Free tmpname.

Diff:
---
 binutils/ChangeLog | 5 +++++
 binutils/objcopy.c | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 3f20d7f..a469e37 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2017-11-15  Alan Modra  <amodra@gmail.com>
+
+	PR 22426
+	* objcopy.c (copy_main): Free tmpname.
+
 2017-11-15  Nick Clifton  <nickc@redhat.com>
 
 	PR 15152
diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index e5df1a9..c45133b 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -5301,6 +5301,9 @@ copy_main (int argc, char *argv[])
   else
     unlink_if_ordinary (tmpname);
 
+  if (tmpname != output_filename)
+    free (tmpname);
+
   if (change_warn)
     {
       struct section_list *p;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]