This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0
- From: H.J.Lu <hjl at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 22 Sep 2017 14:27:31 -0000
- Subject: [binutils-gdb] x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b69e9267d15a09ce3f3d4599eae2952dfc6df502
commit b69e9267d15a09ce3f3d4599eae2952dfc6df502
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Fri Sep 22 07:25:16 2017 -0700
x86: Return -1 if bfd_canonicalize_dynamic_reloc returns 0
Stop if bfd_canonicalize_dynamic_reloc returns 0.
PR ld/22163
* elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Also return
-1 if bfd_canonicalize_dynamic_reloc returns 0.
Diff:
---
bfd/ChangeLog | 6 ++++++
bfd/elfxx-x86.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 46643eb..1df9691 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2017-09-22 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/22163
+ * elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Also return
+ -1 if bfd_canonicalize_dynamic_reloc returns 0.
+
2017-09-22 Pedro Alves <palves@redhat.com>
Alan Modra <amodra@gmail.com>
diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c
index 2145308..11883de 100644
--- a/bfd/elfxx-x86.c
+++ b/bfd/elfxx-x86.c
@@ -1807,7 +1807,7 @@ _bfd_x86_elf_get_synthetic_symtab (bfd *abfd,
dynrelcount = bfd_canonicalize_dynamic_reloc (abfd, dynrelbuf,
dynsyms);
- if (dynrelcount < 0)
+ if (dynrelcount <= 0)
return -1;
/* Sort the relocs by address. */