This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] PR 21266, unstable qsort in bfd/elf64-ppc.c
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 19 Mar 2017 23:59:41 -0000
- Subject: [binutils-gdb] PR 21266, unstable qsort in bfd/elf64-ppc.c
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=aaed6f5be3a41a88cc13c744e88af78f5a42dd5b
commit aaed6f5be3a41a88cc13c744e88af78f5a42dd5b
Author: Alan Modra <amodra@gmail.com>
Date: Mon Mar 20 08:25:50 2017 +1030
PR 21266, unstable qsort in bfd/elf64-ppc.c
PR 21266
* elf64-ppc.c (compare_symbols): Stabilize sort.
Diff:
---
bfd/ChangeLog | 5 +++++
bfd/elf64-ppc.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 5dea352..50e76c2 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2017-03-20 Alan Modra <amodra@gmail.com>
+
+ PR 21266
+ * elf64-ppc.c (compare_symbols): Stabilize sort.
+
2017-03-18 Alan Modra <amodra@gmail.com>
* elf64-ppc.c (struct ppc_link_hash_table): Add
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 1193c1f..ae39032 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -3188,7 +3188,7 @@ compare_symbols (const void *ap, const void *bp)
if ((a->flags & BSF_DYNAMIC) == 0 && (b->flags & BSF_DYNAMIC) != 0)
return 1;
- return 0;
+ return a > b;
}
/* Search SYMS for a symbol of the given VALUE. */