This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb/binutils-2_28-branch] PowerPC64 abort due to dynamic relocs on hidden undefweak
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 7 Mar 2017 04:33:21 -0000
- Subject: [binutils-gdb/binutils-2_28-branch] PowerPC64 abort due to dynamic relocs on hidden undefweak
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0d69827324f704b75ac7e5c2b39219cdd15e790b
commit 0d69827324f704b75ac7e5c2b39219cdd15e790b
Author: Alan Modra <amodra@gmail.com>
Date: Tue Mar 7 11:04:19 2017 +1030
PowerPC64 abort due to dynamic relocs on hidden undefweak
ppc64_elf_relocate_section lacked a check which meant that it emitted
dynamic relocs against a hidden undefweak symbol for which no dynamic
relocs had been allocated.
PR 21224
PR 20519
* elf64-ppc.c (ppc64_elf_relocate_section): Add missing
dyn_relocs check.
Diff:
---
bfd/ChangeLog | 7 +++++++
bfd/elf64-ppc.c | 6 ++++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 459c405..17e7e3b 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,12 @@
2017-03-07 Alan Modra <amodra@gmail.com>
+ PR 21224
+ PR 20519
+ * elf64-ppc.c (ppc64_elf_relocate_section): Add missing
+ dyn_relocs check.
+
+2017-03-07 Alan Modra <amodra@gmail.com>
+
Apply from master
2017-03-02 Alan Modra <amodra@gmail.com>
* elf32-ppc.c (ppc_elf_vle_split16): Correct insn mask typo.
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index e7d4792..3381647 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -14798,8 +14798,10 @@ ppc64_elf_relocate_section (bfd *output_bfd,
break;
if (bfd_link_pic (info)
- ? ((h != NULL && pc_dynrelocs (h))
- || must_be_dyn_reloc (info, r_type))
+ ? ((h == NULL
+ || h->dyn_relocs != NULL)
+ && ((h != NULL && pc_dynrelocs (h))
+ || must_be_dyn_reloc (info, r_type)))
: (h != NULL
? h->dyn_relocs != NULL
: ELF_ST_TYPE (sym->st_info) == STT_GNU_IFUNC))