This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] [GOLD] PowerPC64 TOC indirect to TOC relative segfault
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 3 Feb 2017 09:37:18 -0000
- Subject: [binutils-gdb] [GOLD] PowerPC64 TOC indirect to TOC relative segfault
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e666304ec603bb3249f80bac97200f2b4520ab0f
commit e666304ec603bb3249f80bac97200f2b4520ab0f
Author: Alan Modra <amodra@gmail.com>
Date: Fri Feb 3 19:18:37 2017 +1030
[GOLD] PowerPC64 TOC indirect to TOC relative segfault
* powerpc.cc (Powerpc_relobj::make_toc_relative): Don't crash
when no .toc section exists.
Diff:
---
gold/ChangeLog | 5 +++++
gold/powerpc.cc | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/gold/ChangeLog b/gold/ChangeLog
index c50e1f8..56fe966 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,8 @@
+2017-02-03 Alan Modra <amodra@gmail.com>
+
+ * powerpc.cc (Powerpc_relobj::make_toc_relative): Don't crash
+ when no .toc section exists.
+
2017-01-31 Cary Coutant <ccoutant@gmail.com>
PR gold/21090
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index a67c336..4abfcec 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -1986,6 +1986,12 @@ Powerpc_relobj<size, big_endian>::make_toc_relative(
if (size != 64)
return false;
+ // With -mcmodel=medium code it is quite possible to have
+ // toc-relative relocs referring to objects outside the TOC.
+ // Don't try to look at a non-existent TOC.
+ if (this->toc_shndx() == 0)
+ return false;
+
// Convert VALUE back to an address by adding got_base (see below),
// then to an offset in the TOC by subtracting the TOC output
// section address and the TOC output offset. Since this TOC output