This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Check for shared lib support before running ld tests with -shared
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 3 Jan 2017 23:10:38 -0000
- Subject: [binutils-gdb] Check for shared lib support before running ld tests with -shared
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=47523653a331d0a04470701338a6ed269cc758f4
commit 47523653a331d0a04470701338a6ed269cc758f4
Author: Alan Modra <amodra@gmail.com>
Date: Wed Jan 4 09:25:54 2017 +1030
Check for shared lib support before running ld tests with -shared
Another fix now that we run these tests non-native.
* testsuite/ld-elf/audit.exp: Check for shared lib support.
* testsuite/ld-elf/compress.exp: Likewise.
* testsuite/ld-elf/dwarf.exp: Likewise.
* testsuite/ld-elf/shared.exp: Likewise.
* testsuite/ld-elf/wrap.exp: Likewise.
* testsuite/ld-ifunc/ifunc.exp: Likewise.
* testsuite/ld-plugin/lto.exp: Check $CXX exists.
Diff:
---
ld/ChangeLog | 10 ++++++++++
ld/testsuite/ld-elf/audit.exp | 6 ++++++
ld/testsuite/ld-elf/compress.exp | 6 ++++++
ld/testsuite/ld-elf/dwarf.exp | 6 ++++++
ld/testsuite/ld-elf/shared.exp | 6 ++++++
ld/testsuite/ld-elf/wrap.exp | 6 ++++++
ld/testsuite/ld-ifunc/ifunc.exp | 6 ++++++
ld/testsuite/ld-plugin/lto.exp | 4 ++--
8 files changed, 48 insertions(+), 2 deletions(-)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index b6a8284..b855c74 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,13 @@
+2017-01-04 Alan Modra <amodra@gmail.com>
+
+ * testsuite/ld-elf/audit.exp: Check for shared lib support.
+ * testsuite/ld-elf/compress.exp: Likewise.
+ * testsuite/ld-elf/dwarf.exp: Likewise.
+ * testsuite/ld-elf/shared.exp: Likewise.
+ * testsuite/ld-elf/wrap.exp: Likewise.
+ * testsuite/ld-ifunc/ifunc.exp: Likewise.
+ * testsuite/ld-plugin/lto.exp: Check $CXX exists.
+
2017-01-03 Alan Modra <amodra@gmail.com>
* testsuite/lib/ld-lib.exp (run_ld_link_exec_tests): Do not
diff --git a/ld/testsuite/ld-elf/audit.exp b/ld/testsuite/ld-elf/audit.exp
index aad5339..83ee355 100644
--- a/ld/testsuite/ld-elf/audit.exp
+++ b/ld/testsuite/ld-elf/audit.exp
@@ -25,6 +25,12 @@ if ![is_elf_format] {
return
}
+# Skip targets where -shared is not supported
+
+if ![check_shared_lib_support] {
+ return
+}
+
# Check if compiler works
if { [which $CC] == 0 } {
return
diff --git a/ld/testsuite/ld-elf/compress.exp b/ld/testsuite/ld-elf/compress.exp
index b2b6ca1..5620f3c 100644
--- a/ld/testsuite/ld-elf/compress.exp
+++ b/ld/testsuite/ld-elf/compress.exp
@@ -25,6 +25,12 @@ if ![is_elf_format] {
return
}
+# Skip targets where -shared is not supported
+
+if ![check_shared_lib_support] {
+ return
+}
+
# Check if compiler works
if { [which $CC] == 0 } {
return
diff --git a/ld/testsuite/ld-elf/dwarf.exp b/ld/testsuite/ld-elf/dwarf.exp
index 572c704..529ebcc 100644
--- a/ld/testsuite/ld-elf/dwarf.exp
+++ b/ld/testsuite/ld-elf/dwarf.exp
@@ -29,6 +29,12 @@ if ![is_elf_format] {
return
}
+# Skip targets where -shared is not supported
+
+if ![check_shared_lib_support] {
+ return
+}
+
# Check if compiler works
if { [which $CC] == 0 } {
return
diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp
index aac3acc..f38cd7b 100644
--- a/ld/testsuite/ld-elf/shared.exp
+++ b/ld/testsuite/ld-elf/shared.exp
@@ -25,6 +25,12 @@ if ![is_elf_format] {
return
}
+# Skip targets where -shared is not supported
+
+if ![check_shared_lib_support] {
+ return
+}
+
# Check to see if the C compiler works
if { [which $CC] == 0 } {
return
diff --git a/ld/testsuite/ld-elf/wrap.exp b/ld/testsuite/ld-elf/wrap.exp
index 4bf8faa..4a166be 100644
--- a/ld/testsuite/ld-elf/wrap.exp
+++ b/ld/testsuite/ld-elf/wrap.exp
@@ -25,6 +25,12 @@ if ![is_elf_format] {
return
}
+# Skip targets where -shared is not supported
+
+if ![check_shared_lib_support] {
+ return
+}
+
# Check if compiler works
if { [which $CC] == 0 } {
return
diff --git a/ld/testsuite/ld-ifunc/ifunc.exp b/ld/testsuite/ld-ifunc/ifunc.exp
index d7519b5..ffff2f1 100644
--- a/ld/testsuite/ld-ifunc/ifunc.exp
+++ b/ld/testsuite/ld-ifunc/ifunc.exp
@@ -41,6 +41,12 @@ if {!(([istarget "i?86-*-*"]
return
}
+# Skip targets where -shared is not supported
+
+if ![check_shared_lib_support] {
+ return
+}
+
# We need a working compiler. (Strictly speaking this is
# not true, we could use target specific assembler files).
if { [which $CC] == 0 } {
diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp
index b13c540..b525acf 100644
--- a/ld/testsuite/ld-plugin/lto.exp
+++ b/ld/testsuite/ld-plugin/lto.exp
@@ -18,8 +18,8 @@
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
# MA 02110-1301, USA.
-# Check to see if the C compiler works
-if { [which $CC] == 0 } {
+# Check to see if the C and C++ compilers work
+if { [which $CC] == 0 || [which $CXX] == 0 } {
return
}