This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] metag: make an array's type unsigned char[]
- From: Trevor Saunders <tbsaunde at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 26 May 2016 12:39:18 -0000
- Subject: [binutils-gdb] metag: make an array's type unsigned char[]
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=81cead6f5e9b765788483ad66f490f7540264eba
commit 81cead6f5e9b765788483ad66f490f7540264eba
Author: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Date: Mon May 23 07:42:14 2016 -0400
metag: make an array's type unsigned char[]
It contains values between 128 and 256 which fit in an unsigned char, but not a
signed char, so we should explicitly use unsigned char to not rely on how these
values are converted to signed char.
gas/ChangeLog:
2016-05-26 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* config/tc-metag.c (metag_handle_align): Make the type of noop
unsigned char.
Diff:
---
gas/ChangeLog | 5 +++++
gas/config/tc-metag.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index ae4de64..b21e332 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,10 @@
2016-05-26 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
+ * config/tc-metag.c (metag_handle_align): Make the type of noop
+ unsigned char.
+
+2016-05-26 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
+
* config/tc-rx.c (md_convert_frag): Make the type of reloc_type
bfd_reloc_code_real_type.
diff --git a/gas/config/tc-metag.c b/gas/config/tc-metag.c
index 1c45924..a6c7152 100644
--- a/gas/config/tc-metag.c
+++ b/gas/config/tc-metag.c
@@ -6847,7 +6847,7 @@ md_convert_frag (bfd * abfd ATTRIBUTE_UNUSED, segT sec ATTRIBUTE_UNUSED,
void
metag_handle_align (fragS * fragP)
{
- static char const noop[4] = { 0xfe, 0xff, 0xff, 0xa0 };
+ static unsigned char const noop[4] = { 0xfe, 0xff, 0xff, 0xa0 };
int bytes, fix;
char *p;