This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Properly skip IFUNC relocations in debug sections
- From: H.J.Lu <hjl at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 12 Aug 2015 02:06:08 -0000
- Subject: [binutils-gdb] Properly skip IFUNC relocations in debug sections
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0eace2105dc6c005fdc908414ad564d318b71540
commit 0eace2105dc6c005fdc908414ad564d318b71540
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Tue Aug 11 19:04:38 2015 -0700
Properly skip IFUNC relocations in debug sections
Use "continue" instead of "break" to skip IFUNC relocations in debug
sections.
* elf32-i386.c (elf_i386_relocate_section): Properly skip IFUNC
relocations in debug sections.
* elf64-x86-64.c (elf_x86_64_relocate_section): Likewise.
Diff:
---
bfd/ChangeLog | 6 ++++++
bfd/elf32-i386.c | 2 +-
bfd/elf64-x86-64.c | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1e02625..2f850e7 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2015-08-11 H.J. Lu <hongjiu.lu@intel.com>
+
+ * elf32-i386.c (elf_i386_relocate_section): Properly skip IFUNC
+ relocations in debug sections.
+ * elf64-x86-64.c (elf_x86_64_relocate_section): Likewise.
+
2015-08-11 Jiong Wang <jiong.wang@arm.com>
* elfnn-aarch64.c (elfNN_aarch64_relocate_section): Improve warning
diff --git a/bfd/elf32-i386.c b/bfd/elf32-i386.c
index fb87421..98902ac 100644
--- a/bfd/elf32-i386.c
+++ b/bfd/elf32-i386.c
@@ -3509,7 +3509,7 @@ elf_i386_relocate_section (bfd *output_bfd,
sections because such sections are not SEC_ALLOC and
thus ld.so will not process them. */
if ((input_section->flags & SEC_DEBUGGING) != 0)
- break;
+ continue;
abort ();
}
else if (h->plt.offset == (bfd_vma) -1)
diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c
index 4b83032..b3c8522 100644
--- a/bfd/elf64-x86-64.c
+++ b/bfd/elf64-x86-64.c
@@ -3792,7 +3792,7 @@ elf_x86_64_relocate_section (bfd *output_bfd,
sections because such sections are not SEC_ALLOC and
thus ld.so will not process them. */
if ((input_section->flags & SEC_DEBUGGING) != 0)
- break;
+ continue;
abort ();
}
else if (h->plt.offset == (bfd_vma) -1)