This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Downgrade linker error on protected symbols in .dynbss to a warning
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 10 Apr 2015 09:47:25 -0000
- Subject: [binutils-gdb] Downgrade linker error on protected symbols in .dynbss to a warning
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d07a1b059d790af3da88b9c750925d5a8db51250
commit d07a1b059d790af3da88b9c750925d5a8db51250
Author: Alan Modra <amodra@gmail.com>
Date: Fri Apr 10 10:09:34 2015 +0930
Downgrade linker error on protected symbols in .dynbss to a warning
PR ld/18222
* elflink.c (_bfd_elf_adjust_dynamic_copy): Don't report an error
on adding a protected visibility variable to .dynbss.
Diff:
---
bfd/ChangeLog | 6 ++++++
bfd/elflink.c | 10 +++-------
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index f1d9343..f50ae75 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,11 @@
2015-04-10 Alan Modra <amodra@gmail.com>
+ PR ld/18222
+ * elflink.c (_bfd_elf_adjust_dynamic_copy): Don't report an error
+ on adding a protected visibility variable to .dynbss.
+
+2015-04-10 Alan Modra <amodra@gmail.com>
+
Revert 2015-03-05 H.J. Lu <hongjiu.lu@intel.com>
PR ld/pr15228
PR ld/pr17709
diff --git a/bfd/elflink.c b/bfd/elflink.c
index 183b313..5bc9e9b 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -2674,13 +2674,9 @@ _bfd_elf_adjust_dynamic_copy (struct bfd_link_info *info,
dynbss->size += h->size;
if (h->protected_def)
- {
- info->callbacks->einfo
- (_("%P: copy reloc against protected `%T' is invalid\n"),
- h->root.root.string);
- bfd_set_error (bfd_error_bad_value);
- return FALSE;
- }
+ info->callbacks->einfo
+ (_("%P: copy reloc against protected `%T' is dangerous\n"),
+ h->root.root.string);
return TRUE;
}