This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Adding test case for abuse of :got: in offset load
- From: Marcus Shawcroft <mshawcroft at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 26 Feb 2015 22:29:49 -0000
- Subject: [binutils-gdb] Adding test case for abuse of :got: in offset load
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=27228ca23e80c31ecbf3da261224b1d2ece4be83
commit 27228ca23e80c31ecbf3da261224b1d2ece4be83
Author: Marcus Shawcroft <marcus.shawcroft@arm.com>
Date: Wed Feb 18 18:32:43 2015 +0000
Adding test case for abuse of :got: in offset load
The :got: modifier is not meaningful in a register offset load store
instruction and should result in a diagnostic.
Diff:
---
gas/testsuite/ChangeLog | 5 +++++
gas/testsuite/gas/aarch64/diagnostic.l | 1 +
gas/testsuite/gas/aarch64/diagnostic.s | 1 +
3 files changed, 7 insertions(+)
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index 8884e35..630fa91 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2015-02-26 Marcus Shawcroft <marcus.shawcroft@arm.com>
+ * gas/aarch64/diagnostic.s: Add LDR test.
+ * gas/aarch64/diagnostic.l: Likewise.
+
+2015-02-26 Marcus Shawcroft <marcus.shawcroft@arm.com>
+
* gas/aarch64/diagnostic.s: Add ADR test.
* gas/aarch64/diagnostic.l: Likewise.
diff --git a/gas/testsuite/gas/aarch64/diagnostic.l b/gas/testsuite/gas/aarch64/diagnostic.l
index 50f2a6d..7a89f8e 100644
--- a/gas/testsuite/gas/aarch64/diagnostic.l
+++ b/gas/testsuite/gas/aarch64/diagnostic.l
@@ -115,3 +115,4 @@
[^:]*:124: Warning: unpredictable transfer with writeback -- `stp x0,x1,\[x0,#16\]!'
[^:]*:125: Warning: unpredictable transfer with writeback -- `ldp x0,x1,\[x1\],#16'
[^:]*:126: Error: this relocation modifier is not allowed on this instruction at operand 2 -- `adr x2,:got:s1'
+[^:]*:127: Error: this relocation modifier is not allowed on this instruction at operand 2 -- `ldr x0,\[x0,:got:s1\]'
diff --git a/gas/testsuite/gas/aarch64/diagnostic.s b/gas/testsuite/gas/aarch64/diagnostic.s
index 6dbe6e1..7650b65 100644
--- a/gas/testsuite/gas/aarch64/diagnostic.s
+++ b/gas/testsuite/gas/aarch64/diagnostic.s
@@ -124,3 +124,4 @@
stp x0, x1, [x0, #16]!
ldp x0, x1, [x1], #16
adr x2, :got:s1
+ ldr x0, [x0, :got:s1]