This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Avoid incrementing uninitialized variable
- From: H.J.Lu <hjl at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 9 Feb 2015 21:56:13 -0000
- Subject: [binutils-gdb] Avoid incrementing uninitialized variable
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=35181b3eaa305458f1a6ff04b97cf13e2ef10946
commit 35181b3eaa305458f1a6ff04b97cf13e2ef10946
Author: Ed Maste <emaste@freebsd.org>
Date: Mon Feb 9 13:55:34 2015 -0800
Avoid incrementing uninitialized variable
* elf32-i386.c (elf_i386_get_plt_sym_val): Avoid incrementing
uninitialized and unused variable.
* elf64-x86-64.c (elf_x86_64_get_plt_sym_val): Likewise.
Diff:
---
bfd/ChangeLog | 6 ++++++
bfd/elf32-i386.c | 2 +-
bfd/elf64-x86-64.c | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 21ce154..650e8ee 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2015-02-09 Ed Maste <emaste@freebsd.org>
+
+ * elf32-i386.c (elf_i386_get_plt_sym_val): Avoid incrementing
+ uninitialized and unused variable.
+ * elf64-x86-64.c (elf_x86_64_get_plt_sym_val): Likewise.
+
2015-02-09 Alan Modra <amodra@gmail.com>
* elf32-ppc.c (ppc_elf_relocate_section): Don't segfault on NULL
diff --git a/bfd/elf32-i386.c b/bfd/elf32-i386.c
index dd4dbdc..452ec54 100644
--- a/bfd/elf32-i386.c
+++ b/bfd/elf32-i386.c
@@ -5187,7 +5187,7 @@ bad_return:
if (plt_sym_val == NULL)
goto bad_return;
- for (i = 0; i < count; i++, p++)
+ for (i = 0; i < count; i++)
plt_sym_val[i] = -1;
plt_offset = bed->plt->plt_entry_size;
diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c
index 5fd727b..fd9c726 100644
--- a/bfd/elf64-x86-64.c
+++ b/bfd/elf64-x86-64.c
@@ -5569,7 +5569,7 @@ bad_return:
if (plt_sym_val == NULL)
goto bad_return;
- for (i = 0; i < count; i++, p++)
+ for (i = 0; i < count; i++)
plt_sym_val[i] = -1;
plt_offset = bed->plt_entry_size;