Re: envariable check still buggy

[Jim Meyering <meyering@ascend.com>]

Volker,

Thanks for the report and patch.
I think you're saying the problem is that the envvar check rule
is run only after all the `check' tests are run, Right?

Unfortunately, Makefile.in is automatically generated from Makefile.am
and I don't know of a way to add a pre-check hook.  Maybe someone on
the automake list knows of a way to cause automake to emit a Makefile.in
with a pre-check rule?

I'll apply your $(srcdir)/-adding part to Makefile.am.

Regards,
Jim

Volker Borchert <bt@teknon.de> writes:
| I just did a quick build of the latest betas, and found that the
| envariable check was still buggy. The diffs below work for me,
| but then I'm not too familiar with auto(make|conf|header)...
| This is for fileutils, but sh-utils and textutils share both
| problems and diffs.
|
| No other problems on both SunOS 4.1.4 and OpenBSD 2.3 so far.
|
| 	Volker
|
|
|
| --- ,ChangeLog	Sun May 23 22:44:30 1999
| +++ ChangeLog	Thu May 27 06:31:40 1999
| @@ -0,0 +1,6 @@
| +1999-05-27  Volker Borchert  <bt@teknon.de>
| +
| +	* tests/Makefile.in: Put dependencies for check on a single
| +	line to be sure they are checked and made in the right order.
| +	The .env-warn file is in $(srcdir).
| +
|
|
|
| --- tests/,Makefile.in	Sun May 23 23:13:10 1999
| +++ tests/Makefile.in	Thu May 27 06:22:29 1999
| @@ -238,7 +238,7 @@
|  dvi-am:
|  dvi: dvi-recursive
|  check-am: all-am
| -check: check-recursive
| +check: envvar-check check-recursive
|  installcheck-am:
|  installcheck: installcheck-recursive
|  install-exec-am:
| @@ -303,14 +303,13 @@
|  maintainer-clean
|
|
| -check: envvar-check
|
|  # Warn when `make check' is run with POSIXLY_CORRECT or CDPATH set.
|  envvar-check:
|  	test "$${POSIXLY_CORRECT+set}" = set \
| -	  && sed s/%%/POSIXLY_CORRECT/ .env-warn || :
| +	  && sed s/%%/POSIXLY_CORRECT/ $(srcdir)/.env-warn || :
|  	test "$${CDPATH+set}" = set \
| -	  && sed s/%%/CDPATH/ .env-warn || :
| +	  && sed s/%%/CDPATH/ $(srcdir)/.env-warn || :
|
|  # Tell versions [3.59,3.63) of GNU make to not export all variables.
|  # Otherwise a system limit (for SysV at least) may be exceeded.