This is the mail archive of the
automake@gnu.org
mailing list for the automake project.
distcheck-hook problem
- To: automake@gnu.org
- Subject: distcheck-hook problem
- From: Jim Meyering <meyering@ascend.com>
- Date: 07 May 1999 15:44:21 -0500
A failed `$(MAKE) distcheck-hook' doesn't result in top-level make failure.
Demonstrate it with a Makefile.am containing this:
distcheck-hook:
false
Here's a patch:
1999-05-07 Jim Meyering <meyering@ascend.com>
* automake.in (handle_dist): Change emitted rules so that a failure
in `$(MAKE) distcheck-hook' propagates to the outer make.
Index: automake.in
===================================================================
RCS file: /cvs/automake/automake/automake.in,v
retrieving revision 1.729
diff -u -p -r1.729 automake.in
--- automake.in 1999/05/05 09:22:35 1.729
+++ automake.in 1999/05/07 20:26:31
@@ -2864,13 +2864,13 @@ distcheck: dist
GZIP=$(GZIP_ENV) gunzip -c $(distdir).tar.gz | $(AMTAR) xf -
mkdir $(distdir)/=build
mkdir $(distdir)/=inst
- dc_install_base=`cd $(distdir)/=inst && pwd`; \\'
+ dc_install_base=`cd $(distdir)/=inst && pwd` \\'
. (&target_defined ('distcheck-hook')
- ? ("\n\t\$(MAKE) \$(AM_MAKEFLAGS)"
- . " distcheck-hook; \\")
+ ? ("\n\t && \$(MAKE) \$(AM_MAKEFLAGS)"
+ . " distcheck-hook \\")
: '')
. '
- cd $(distdir)/=build \\
+ && cd $(distdir)/=build \\
&& ../configure '
. ($seen_gettext ? '--with-included-gettext ' : '')