This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for pascal-dynamic arrays


On Wed, 30 Sep 2009 17:59:34 +0200, Joost van der Sluis wrote:
> Attached it the new patch.

Please write GNU style ChangeLog entry for it.  I am sorry I did not write the
entries myself in the log (as a partial excuse it was not reviewed by anyone
that time).


> I tested it and I have no regressions anymore.

Getting a lot of regressions included below.
* Some fortran failures only happen with `ulimit -v 500000'.
* Are the new Pascal testcase FAILures expected?  If a more recent fpc is
  required the testcase should XFAIL, not FAIL.

You need to have installed at least gcc-gfortran + gcc-gnat with
	ln -s /usr/bin/gfortran src-toplevel-dir/g77


> @@ -197,6 +198,13 @@ struct value
>    /* If value is a variable, is it initialized or not.  */
>    int initialized;
>  
> +  CORE_ADDR data_address;
> +
> +  char calc_length;
> +  long length;
> +  char checked_dynamics;
> +  long lower_bound;
> +  long upper_bound;


Still I do not like duplicating the information already present in `struct
main_type'.  I find right you have changed passing some `struct type *' to
`struct value *' instead but that new `struct value' just could use
copy_type_recursive on that linked `struct type'.



Regards,
Jan


-PASS: gdb.ada/array_return.exp: value printed by finish of Create_Small
+FAIL: gdb.ada/array_return.exp: value printed by finish of Create_Small (GDB internal error)
-PASS: gdb.ada/array_return.exp: value printed by finish of Create_Large
+FAIL: gdb.ada/array_return.exp: value printed by finish of Create_Large (GDB internal error)
-PASS: gdb.ada/array_return.exp: value printed by finish of Create_Small_Float_Vector
+FAIL: gdb.ada/array_return.exp: value printed by finish of Create_Small_Float_Vector (GDB internal error)
-PASS: gdb.ada/arrayidx.exp: print one_two_three, indexes off
-FAIL: gdb.ada/arrayidx.exp: print e_one_two_three, indexes off
-FAIL: gdb.ada/arrayidx.exp: print r_two_three, indexes off
-PASS: gdb.ada/arrayidx.exp: print u_one_two_three, indexes off
-PASS: gdb.ada/arrayidx.exp: print p_one_two_three, indexes off
-PASS: gdb.ada/arrayidx.exp: print few_reps, indexes off
-PASS: gdb.ada/arrayidx.exp: print many_reps, indexes off
-PASS: gdb.ada/arrayidx.exp: print empty, indexes off
+FAIL: gdb.ada/arrayidx.exp: print one_two_three, indexes off (GDB internal error)
+FAIL: gdb.ada/arrayidx.exp: print e_one_two_three, indexes off (GDB internal error)
+FAIL: gdb.ada/arrayidx.exp: print r_two_three, indexes off (GDB internal error)
+FAIL: gdb.ada/arrayidx.exp: print u_one_two_three, indexes off (GDB internal error)
+FAIL: gdb.ada/arrayidx.exp: print p_one_two_three, indexes off (GDB internal error)
+FAIL: gdb.ada/arrayidx.exp: print few_reps, indexes off (GDB internal error)
+FAIL: gdb.ada/arrayidx.exp: print many_reps, indexes off (GDB internal error)
+FAIL: gdb.ada/arrayidx.exp: print empty, indexes off (GDB internal error)
-PASS: gdb.ada/mod_from_name.exp: print xp
+FAIL: gdb.ada/mod_from_name.exp: print xp (GDB internal error)
-PASS: gdb.ada/null_array.exp: print my_matrix
+FAIL: gdb.ada/null_array.exp: print my_matrix (GDB internal error)
-PASS: gdb.ada/packed_array.exp: print var
+FAIL: gdb.ada/packed_array.exp: print var (GDB internal error)
-PASS: gdb.ada/packed_array.exp: print &var
+FAIL: gdb.ada/packed_array.exp: print &var (GDB internal error)
-PASS: gdb.ada/type_coercion.exp: p q
+FAIL: gdb.ada/type_coercion.exp: p q (GDB internal error)
-PASS: gdb.ada/type_coercion.exp: p q
+FAIL: gdb.ada/type_coercion.exp: p q (GDB internal error)
-PASS: gdb.ada/variant_record_packed_array.exp: print empty
+FAIL: gdb.ada/variant_record_packed_array.exp: print empty (GDB internal error)
-PASS: gdb.fortran/dwarf-stride.exp: p c40pt(1)
-PASS: gdb.fortran/dwarf-stride.exp: p c40pt(2)
+FAIL: gdb.fortran/dwarf-stride.exp: p c40pt(1) (GDB internal error)
+FAIL: gdb.fortran/dwarf-stride.exp: p c40pt(2) (GDB internal error)
-PASS: gdb.fortran/dynamic.exp: ptype varx allocated
+FAIL: gdb.fortran/dynamic.exp: ptype varx allocated (GDB internal error)
-PASS: gdb.fortran/dynamic.exp: p varx(2, 5, 17)
-PASS: gdb.fortran/dynamic.exp: p varx(1, 5, 17)
-PASS: gdb.fortran/dynamic.exp: p varx(2, 6, 18)
-PASS: gdb.fortran/dynamic.exp: p varx(6, 15, 28)
+FAIL: gdb.fortran/dynamic.exp: p varx(2, 5, 17) (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p varx(1, 5, 17) (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p varx(2, 6, 18) (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p varx(6, 15, 28) (GDB internal error)
-PASS: gdb.fortran/dynamic.exp: p varx(3, 7, 19) with varv associated
-PASS: gdb.fortran/dynamic.exp: p varv(3, 7, 19) associated
+FAIL: gdb.fortran/dynamic.exp: p varx(3, 7, 19) with varv associated (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p varv(3, 7, 19) associated (GDB internal error)
-PASS: gdb.fortran/dynamic.exp: ptype varx with varv associated
-PASS: gdb.fortran/dynamic.exp: ptype varv associated
+FAIL: gdb.fortran/dynamic.exp: ptype varx with varv associated (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: ptype varv associated (GDB internal error)
-PASS: gdb.fortran/dynamic.exp: p varx(3, 7, 19) with varv filled
-PASS: gdb.fortran/dynamic.exp: p varv(3, 7, 19) filled
+FAIL: gdb.fortran/dynamic.exp: p varx(3, 7, 19) with varv filled (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p varv(3, 7, 19) filled (GDB internal error)
-PASS: gdb.fortran/dynamic.exp: continue to breakpoint: vary-passed
-PASS: gdb.fortran/dynamic.exp: p vary
-PASS: gdb.fortran/dynamic.exp: continue to breakpoint: vary-filled
-PASS: gdb.fortran/dynamic.exp: ptype vary
-PASS: gdb.fortran/dynamic.exp: p vary(1, 1)
-PASS: gdb.fortran/dynamic.exp: p vary(2, 2)
-PASS: gdb.fortran/dynamic.exp: p vary(1, 3)
-PASS: gdb.fortran/dynamic.exp: p varw
-PASS: gdb.fortran/dynamic.exp: continue to breakpoint: varw-almostfilled
-PASS: gdb.fortran/dynamic.exp: ptype varw
+FAIL: gdb.fortran/dynamic.exp: continue to breakpoint: vary-passed (timeout)
+FAIL: gdb.fortran/dynamic.exp: p vary (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: continue to breakpoint: vary-filled (timeout)
+FAIL: gdb.fortran/dynamic.exp: ptype vary (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p vary(1, 1) (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p vary(2, 2) (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p vary(1, 3) (GDB internal error)
+FAIL: gdb.fortran/dynamic.exp: p varw
+FAIL: gdb.fortran/dynamic.exp: continue to breakpoint: varw-almostfilled (timeout)
+FAIL: gdb.fortran/dynamic.exp: ptype varw (GDB internal error)
-PASS: gdb.fortran/dynamic.exp: p varw filled
-PASS: gdb.fortran/dynamic.exp: finish
-PASS: gdb.fortran/dynamic.exp: p z(2,4,5)
-PASS: gdb.fortran/dynamic.exp: p z(2,4,6)
-PASS: gdb.fortran/dynamic.exp: p z(2,4,7)
-PASS: gdb.fortran/dynamic.exp: p z(4,4,6)
-PASS: gdb.fortran/dynamic.exp: continue to breakpoint: varz-almostfilled
-PASS: gdb.fortran/dynamic.exp: ptype varz
-PASS: gdb.fortran/dynamic.exp: ptype vart
-PASS: gdb.fortran/dynamic.exp: p varz
-PASS: gdb.fortran/dynamic.exp: p vart
-PASS: gdb.fortran/dynamic.exp: p varz(3)
-PASS: gdb.fortran/dynamic.exp: p vart(2,7)
-PASS: gdb.fortran/dynamic.exp: p vart(3,8)
-PASS: gdb.fortran/dynamic.exp: p vart(2,9)
+FAIL: gdb.fortran/dynamic.exp: p varw filled
+FAIL: gdb.fortran/dynamic.exp: finish (GDB internal error)
+ERROR: Could not resync from internal error (timeout)
+UNRESOLVED: gdb.fortran/dynamic.exp: p z(2,4,5) (timeout)
+FAIL: gdb.fortran/dynamic.exp: p z(2,4,6) (timeout)
+FAIL: gdb.fortran/dynamic.exp: p z(2,4,7) (timeout)
+FAIL: gdb.fortran/dynamic.exp: p z(4,4,6) (timeout)
+FAIL: gdb.fortran/dynamic.exp: setting breakpoint at 68 (timeout)
+FAIL: gdb.fortran/dynamic.exp: continue to breakpoint: varz-almostfilled (timeout)
+FAIL: gdb.fortran/dynamic.exp: ptype varz (timeout)
+FAIL: gdb.fortran/dynamic.exp: ptype vart (timeout)
+FAIL: gdb.fortran/dynamic.exp: p varz (timeout)
+FAIL: gdb.fortran/dynamic.exp: p vart (timeout)
+FAIL: gdb.fortran/dynamic.exp: p varz(3) (timeout)
+FAIL: gdb.fortran/dynamic.exp: p vart(2,7) (timeout)
+FAIL: gdb.fortran/dynamic.exp: p vart(3,8) (timeout)
+FAIL: gdb.fortran/dynamic.exp: p vart(2,9) (timeout)

+Running ./gdb.pascal/arrays.exp ...
+PASS: gdb.pascal/arrays.exp: setting breakpoint 1
+PASS: gdb.pascal/arrays.exp: setting breakpoint 2
+PASS: gdb.pascal/arrays.exp: start
+PASS: gdb.pascal/arrays.exp: Going to first breakpoint
+PASS: gdb.pascal/arrays.exp: Print static array of integer type
+PASS: gdb.pascal/arrays.exp: Print static array of integer
+PASS: gdb.pascal/arrays.exp: Going to second breakpoint
+FAIL: gdb.pascal/arrays.exp: Print dynamic array of integer type
+FAIL: gdb.pascal/arrays.exp: Print dynamic array of integer
+FAIL: gdb.pascal/arrays.exp: Print string containing null-char
+FAIL: gdb.pascal/arrays.exp: Print dynamic array of string
+FAIL: gdb.pascal/arrays.exp: Print static array of string
+FAIL: gdb.pascal/arrays.exp: Print dynamic array of char
+PASS: gdb.pascal/arrays.exp: Print static array of char
+PASS: gdb.pascal/arrays.exp: Print static 2-dimensional array of integer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]