This is the mail archive of the
archer@sourceware.org
mailing list for the Archer project.
Re: [python][patch] Add options length parameter tovalue.string(...)
- From: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Phil Muldoon <pmuldoon at redhat dot com>, Project Archer <archer at sourceware dot org>
- Date: Mon, 06 Apr 2009 19:32:55 -0300
- Subject: Re: [python][patch] Add options length parameter tovalue.string(...)
- References: <49DA33CE.9070803@redhat.com> <m3myat2zx2.fsf@fleche.redhat.com>
El lun, 06-04-2009 a las 16:14 -0600, Tom Tromey escribiÃ:
> >>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
> The rest looks good to me.
>From what we talked on IRC, in this block:
/* If we know the size of the array, we can use it as a limit on the
number of characters to be fetched. */
if (TYPE_NFIELDS (type) == 1
&& TYPE_CODE (TYPE_FIELD_TYPE (type, 0)) == TYPE_CODE_RANGE)
we want to set *length and not fetchlimit from the array size. But
probably only if *length is -1. If the caller specified a *length
already, we shouldn't override it and continue using the array size for
the fetchlimit.
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center