Bug 6689 - [PATCH] - setup.exe --text-mode and --current-user-only options
Summary: [PATCH] - setup.exe --text-mode and --current-user-only options
Status: ASSIGNED
Alias: None
Product: cygwin
Classification: Unclassified
Component: setup.exe (show other bugs)
Version: unspecified
: P2 enhancement
Target Milestone: ---
Assignee: Dave Korn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-24 11:06 UTC by Reini Urban
Modified: 2008-06-24 11:27 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
goossens-textmode+currentuser against ChangeLog 16 Apr 2008 (913 bytes, patch)
2008-06-24 11:11 UTC, Reini Urban
Details | Diff
goossens-rev1 (724 bytes, patch)
2008-06-24 11:25 UTC, Reini Urban
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Reini Urban 2008-06-24 11:06:19 UTC
http://thread.gmane.org/gmane.os.cygwin.applications/16914

Please consider the following patch to setup. (I tried to follow the 
patch submission guidelines, please correct me if I missed something).

Note that the new commandline options do *not* override the settings of 
a currently existing installation. I chose this behaviour because I'm 
unsure what the effect would be. It would be easy to change this,
though.

The output of setup.exe -h (to the logfile) becomes:

 Command Line Options:
  -D --download                          Download from internet
  -L --local-install                     Install from local directory
  -s --site                              Download site
  -R --root                              Root installation directory
+ -t --text-mode                         Use text mode mount for root
directory
+ -c --current-user-only                 Make cygwin available to the
current
+                                        user only
  -p --proxy                             HTTP/FTP proxy (host:port)
  -q --quiet-mode                        Unattended setup mode
  -h --help                              print help
  -l --local-package-dir                 Local package directory
  -r --no-replaceonreboot                Disable replacing in-use files
on next
                                         reboot.
  -n --no-shortcuts                      Disable creation of desktop and
start
                                         menu shortcuts
  -N --no-startmenu                      Disable creation of start menu
shortcut
  -d --no-desktop                        Disable creation of desktop
shortcut
  -A --disable-buggy-antivirus           Disable known or suspected
buggy anti
                                         virus software packages during
                                         execution.
Comment 1 Reini Urban 2008-06-24 11:11:36 UTC
Created attachment 2790 [details]
goossens-textmode+currentuser against ChangeLog  16 Apr 2008

Against 2.588:

$ patch -b -p0 < goossens-textmode+currentuser.patch
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file root.cc
patch: **** malformed patch at line 26:  #include "mount.h"
Comment 2 Reini Urban 2008-06-24 11:15:05 UTC
Will prepare a clean version
Comment 3 Reini Urban 2008-06-24 11:25:59 UTC
Created attachment 2791 [details]
goossens-rev1

reformatted.
applies cleanly now.