View Bug Activity | Format For Printing
avr-ld fails with --relax, unless --gc-sections is also used, even if -ffunction-sections is not used with avr-gcc.
Hi Eric, Please can you provide a test case for this ? Cheers Nick
Created an attachment (id=2756) Test case. This zip file contains the source code of a project that exhibits the bug, and it contains a short build script. This source code comes from WinAVR (SourceForge) bug #1819125: <http://sourceforge.net/tracker/index.php?func=detail&aid=1819125&group_id=68108&atid=520074>
Unfortunately this is all I have in the way of test case. I know that it is too large, but I haven't had time to investigate into a smaller test case.
Note that in the build script, using -Wl,--relax causes ld to fail. Using -Wl,--relax,--gc-sections causes the link to be successful. This is with a host=mingw toolchain. I have not verified the bug on a host=linux toolchain.
Created an attachment (id=2766) reduced test case test with: avr-gcc -c -o onewire.o -Os onewire.i avr-gcc -Wl,--relax -o onewire.elf onewire.o -Os is necessary and the linker doesn't crash with --gc-sections
I've attached a reduced test case made with multidelta. It got minimized to 11 meaningful lines. It was run through the preprocessor before minimization so the actual code is hard to read but I doubt that really matters.
Created an attachment (id=2768) Add test for no local symbols
Hi Eric, Hi Jevin, Please could you try out the uploaded patch and let me know if it works for you ? (I am especially interested to know if it works on the real programs where you encountered this bug, not just the reduced testcase). Cheers Nick
Patch fixes bug on real-world application. Thanks, Nick!
Hi Guys, Great - I have applied the patch along with the changelog entry below. Cheers Nick bfd/ChangeLog PR ld/6019 * elf32-avr.c (elf32_avr_relax_section): Handle the case where there are no local symbols.