Bug 5659 - frysk.hpd.TestSysRoot contains package public variables
Summary: frysk.hpd.TestSysRoot contains package public variables
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Stan Cox
URL:
Keywords:
Depends on:
Blocks: 5624
  Show dependency tree / graph
 
Reported: 2008-01-22 03:55 UTC by Andrew Cagney
Modified: 2008-01-30 15:08 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2008-01-22 03:55:18 UTC 
For instance:

public class TestSysRoot extends TestLib {
  Expect expect;

when coding we try to make all fields as private as possible; as this way we
benefit from the compilers ability to identify no-longer-used code; if the code
isn't private then the check doesn't work.
Comment 1 Stan Cox 2008-01-30 15:08:53 UTC 
Move installation of test-sysroot to pkglibdir.

* TestSysRoot.java (testHaveSysRoot): test-sysroot now lives in
pkglibdir.  Use sendCommandExpectPrompt.