Bug 5528 - more user_* data conversions needed
Summary: more user_* data conversions needed
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Eugene Teo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-29 12:56 UTC by Frank Ch. Eigler
Modified: 2008-04-03 22:10 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
update testsuite/conversions.exp (359 bytes, patch)
2008-04-03 21:56 UTC, Masami Hiramatsu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Ch. Eigler 2007-12-29 12:56:25 UTC
We need user_{char,int,long,string_n,...} to parallel the kernel_{...}
tapset functions in conversions.stp.
Comment 1 Eugene Teo 2008-03-21 14:38:00 UTC
Patch committed:
http://sources.redhat.com/ml/systemtap-cvs/2008-q1/msg00219.html

Thanks,
Eugene
Comment 2 Eugene Teo 2008-03-22 02:32:16 UTC
[root@rhel5u1-x64 ~]# stap -e 'probe syscall.pipe { printf("%s %d %d %d\n",
execname(), pid(), user_int($fildes), user_int($fildes+4)) }' 
sshd 2085 5 6
sshd 3152 0 0
bash 3154 32 0
bash 3154 32 0
bash 3154 32 0
bash 3154 1 1
bash 3154 1 1
[...]

[root@rhel5u1-x64 ~]# stap -e 'probe syscall.stat { printf("%s %d '%s' '%d'\n",
execname(), pid(), user_string_n_quoted($filename, 10),
user_char_warn($filename)) }' 
init 1 "/dev/i"... 47
init 1 "/dev/i"... 47
sshd 3331 "/var/e"... 47
WARNING: user char copy fault 00002aaaaaed777c
sshd 3331 "/bin/bash" 47
sshd 3331 <unknown 0
init 1 "/dev/i"... 47
init 1 "/dev/i"... 47
WARNING: user char copy fault 000055555559efb9
sshd 3331 "/etc/l"... 47
sshd 3331 "/etc/l"... 47
sshd 3331 "/etc/l"... 47
sshd 3331 "/etc/l"... 47
sshd 3331 "/etc/l"... 47
sshd 3331 "/etc/l"... 47
sshd 3331 "/dev/p"... 47
sshd 3331 "/dev/p"... 47
sshd 3331 "/dev/p"... 47
sshd 3333 <unknown 0
[...]
Comment 3 Masami Hiramatsu 2008-04-03 21:56:57 UTC
Created attachment 2351 [details]
update testsuite/conversions.exp

Hi,

I've gotten below errors with latest snapshot.
---
Running /usr/share/systemtap/testsuite/systemtap.stress/conversions.exp ...
FAIL: conversions.stp 0 (8)
FAIL: conversions.stp 0xffffffff (8)
FAIL: conversions.stp 0xffffffffffffffff (8)
---

This patch updates testsuite/systemtap.stress/conversions.exp to catch up
recently changes of conversions.stp.

Thanks,
Comment 4 Frank Ch. Eigler 2008-04-03 22:10:55 UTC
Thanks, Masami, please commit.