Bug 5273 - x86 arch_validate_probed_insn(): lighten up?
Summary: x86 arch_validate_probed_insn(): lighten up?
Status: RESOLVED WONTFIX
Alias: None
Product: systemtap
Classification: Unclassified
Component: uprobes (show other bugs)
Version: unspecified
: P3 minor
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
: 10324 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-11-05 21:59 UTC by Jim Keniston
Modified: 2015-01-29 01:33 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Keniston 2007-11-05 21:59:23 UTC
In uprobes_i386.c and uprobes_x86_64.c, we spend quite a bit of code on refusing
to probe certain types of instructions, such as undefined opcodes and other
instructions that are likely to yield SIGILL when single-stepped in user mode. 
There's also some paranoia about how instruction prefixes and such might affect
our decisions about which instructions need to be treated specially when
single-stepping them out of line.

We could probably lighten up here.  One disadvantage of the paranoia is that
tests that try to probe (say) EVERY instruction in a .o file will choke on
things like hlt.

For illegal instructions, if the SIGILL kills the task before the SIGTRAP from
the single-step is reported to us -- we need to test this -- then we should be
OK.  Testing suggests that we know how to handle tasks that die of other causes
during probepoint processing.

And I think we've successfully identified instructions that need special
attention during SSOL.  It's probably just a matter of testing each currently
banned instruction type to verify that it doesn't present an unforeseen problem.
Comment 1 Jim Keniston 2009-04-24 21:00:13 UTC
uprobes/uprobes_i386.c has been brought back into sync with the (more tolerant)
uprobes2/uprobes_x86.c.  A couple of changes were ad hoc to address specific
test failures.  Commit af6b060 completes the resync.

We still haven't done any exhaustive testing of the whole instruction set.
Comment 2 Frank Ch. Eigler 2009-08-13 17:47:11 UTC
*** Bug 10324 has been marked as a duplicate of this bug. ***
Comment 3 Frank Ch. Eigler 2015-01-29 01:33:32 UTC
old rhel5 utrace/uprobes is unlikely to be perfected