Bug 5230 - setting proper argument for sys_remap_file_pages.
Summary: setting proper argument for sys_remap_file_pages.
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Srinivasa DS
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-29 08:58 UTC by Srinivasa DS
Modified: 2007-11-01 16:36 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
setting proper argument for systemcall (242 bytes, patch)
2007-10-29 09:01 UTC, Srinivasa DS 		Details | Diff
Same fix with version check (166 bytes, patch)
2007-10-30 18:10 UTC, David Wilder 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Srinivasa DS 2007-10-29 08:58:39 UTC 
My environment is 2.6.24-rc1(ppc64) and systemtap-20071027 snapshot.

Argument for sys_remap_file_pages is not proper and that is causing the tests to
fail.
=================================
semantic error: unable to find local '__prot' near pc 0xc0000000000cbd3c
(alternatives: start size prot pgoff flags mm mapping end vma err
has_write_lock): identifier '$__prot' at
/home/systemtap/tmp/stap_testing_200710290545/install/share/systemtap/tapset/syscalls2.stp:787:9
Pass 2: analysis failed.  Try again with more '-v' (verbose) options.
===================================
Comment 1 Srinivasa DS 2007-10-29 09:01:42 UTC 
Created attachment 2065 [details]
setting proper argument for systemcall

In 2.6.24-rc1
==============================
asmlinkage long sys_remap_file_pages(unsigned long start, unsigned long size,
	unsigned long prot, unsigned long pgoff, unsigned long flags)
{
	struct mm_struct *mm = current->mm;
	struct address_space *mapping;
=======================================
In 2.6.23-rc7
===========================================
asmlinkage long sys_remap_file_pages(unsigned long start, unsigned long size,
	unsigned long __prot, unsigned long pgoff, unsigned long flags)
{
	struct mm_struct *mm = current->mm;
	struct address_space *mapping;
===========================================
Comment 2 David Wilder 2007-10-30 18:10:21 UTC 
Created attachment 2068 [details]
Same fix with version check

I added a kernel version check to the same change.
Comment 3 William Cohen 2007-11-01 16:36:07 UTC 
This correction has been checked into the cvs version of systemtap.