Bug 4612 - Memory Window: Spin buttons do not allow entry of specific addresses
Summary: Memory Window: Spin buttons do not allow entry of specific addresses
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Zhao Shujing
URL:
Keywords:
Depends on:
Blocks: 3119 4870
  Show dependency tree / graph
 
Reported: 2007-06-11 18:16 UTC by Kris Van Hees
Modified: 2007-07-30 06:53 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kris Van Hees 2007-06-11 18:16:40 UTC 
The spin buttons used in the memory window do not allow the user to enter a
specific address.  Since memory examination often involves fairly arbitrary
addresses within the application address range(s), not being able to enter a
specific address imposes a severe limitation on the user.
Comment 1 Kris Van Hees 2007-06-11 18:58:57 UTC 
This also applies to the disassembly window.
Comment 2 Kris Van Hees 2007-07-27 21:10:57 UTC 
Patch by Pearly commited.
Comment 3 Zhao Shujing 2007-07-30 06:53:41 UTC 
Fixed by:
2007-07-23  Zhao Shujing  <pearly.zhao@oracle.com>

        * memory/MemoryWindow.java: fromBox and toBox can be edited. Fixes
        #4612.
        * memory/MemoryWindow.java(handleFromSpin): synchronously display
        column and fromBox when adjust the fromSpin.
        * disassembler/DisassemblyWindow.java: fromBox and toBox can be edited.
        * disassembler/DisassemblyWindow.java(rowAppend): synchronously display
        column and toBox when adjust the toSpin.

There is still one issue left when the value is changed too much than the
lastKnow value, but that is unrelated to the above and seems to be caused by
handleFromSpin and handleToSpin can't handle to add or remove rows too many times.