Bug 4578 - Assertion `...r_state == RT_CONSISTENT' failed!
: Assertion `...r_state == RT_CONSISTENT' failed!
Status: NEW
Product: glibc
Classification: Unclassified
Component: nptl
: 2.3.5
: P2 normal
: ---
Assigned To: Not yet assigned to anyone
:
:
:
:
  Show dependency treegraph
 
Reported: 2007-05-31 18:58 UTC by Larry Stewart
Modified: 2012-12-19 10:39 UTC (History)
1 user (show)

See Also:
Host: mips64-linux-gnu
Target:
Build:
Last reconfirmed:


Attachments
test case (1.23 KB, text/plain)
2007-05-31 19:00 UTC, Larry Stewart
Details
proposed patch (890 bytes, text/plain)
2007-05-31 19:08 UTC, Larry Stewart
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Larry Stewart 2007-05-31 18:58:41 UTC
We hit an assertion in ld.so about every 6000 runs of the cluster manager
slurmstepd on SiCortex hardware.  This is evidently the same bug as

http://www.redhat.com/archives/phil-list/2003-December/msg00008.html

Evidently it has reappeared because of ld.so consistency checking and 
because our chip (6 way SMP at 500 MHz) has a wider window of vulnerability.

We've adapted the previously reported test case so that it fails about half the
time (attached) and developed a patch (attached) that resolves the problem.

The test case doesn't fail for us on opterons, the only other systems we have
available.

The failure message we get on our machines is:

Inconsistency detected by ld.so: dl-open.c: 215: dl_open_worker: Assertion
`_dl_debug_initialize (0, args->nsid)->r_state == RT_CONSISTENT' failed!

Details:

If a thread happens to hold dl_load_lock and have r_state set to RT_ADD or
RT_DELETE at the time another thread calls fork(), then the child exit code
from fork (in nptl/sysdeps/unix/sysv/linux/fork.c in our case) re-initializes
dl_load_lock but does not restore r_state to RT_CONSISTENT. If the child
subsequently requires ld.so functionality before calling exec(), then the
assertion will fire.

The patch acquires dl_load_lock on entry to fork() and releases it on exit
from the parent path.  The child path is initialized as currently done.
This is essentially pthreads_atfork, but forced to be first because the
acquisition of dl_load_lock must happen before malloc_atfork is active
to avoid a deadlock.
Comment 1 Larry Stewart 2007-05-31 19:00:05 UTC
Created attachment 1873 [details]
test case
Comment 2 Larry Stewart 2007-05-31 19:08:50 UTC
Created attachment 1874 [details]
proposed patch
Comment 3 Petr Baudis 2007-06-08 17:49:06 UTC
I think this is a dupe of bug 3429.
Comment 4 Larry Stewart 2007-06-08 18:13:23 UTC
Actually it isn't a duplicate of 3429.  The assertion failure message is the
same,
but it occurs on a different line of the source file, and we applied
the patch for 3429 without fixing our bug.  Sorry I didn't make a more
complete report.