Bug 2831 - soft-fp quad.h broken with 64-bit _FP_W_TYPE, 32-bit long
Summary: soft-fp quad.h broken with 64-bit _FP_W_TYPE, 32-bit long
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: libc (show other bugs)
Version: 2.4
: P2 normal
Target Milestone: ---
Assignee: Ulrich Drepper
URL:
Keywords:
Depends on:
Blocks: 2833
  Show dependency tree / graph
 
Reported: 2006-06-23 15:49 UTC by Joseph Myers
Modified: 2007-03-26 12:04 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Myers 2006-06-23 15:49:59 UTC 
soft-fp's quad.h does not work in the case where two unsigned long 
long words are being used but unsigned long is only 32 bits (as in MIPS64 
N32).

Patch: http://sourceware.org/ml/libc-alpha/2006-06/msg00011.html

If you'd prefer a larger patch where all such bit-fields for all floating-point
formats are changed to _FP_W_TYPE, please let me know.
Comment 1 Daniel Jacobowitz 2006-07-24 15:00:53 UTC 
Has anybody looked at this patch?
Comment 2 Steven Munroe 2006-10-12 18:50:30 UTC 
This patch looks correct.
Comment 3 Sourceware Commits 2007-03-20 12:10:51 UTC 
Subject: Bug 2831

CVSROOT:	/cvs/glibc
Module name:	libc
Changes by:	jakub@sourceware.org	2007-03-20 12:10:36

Modified files:
	.              : ChangeLog 
	soft-fp        : double.h extended.h quad.h 

Log message:
	* soft-fp/double.h (_FP_UNION_D): Use _FP_W_TYPE for frac
	bit-fields.
	* soft-fp/extended.h (_FP_UNION_E): Likewise.
	
	[BZ #2831]
	* soft-fp/quad.h (_FP_UNION_Q): Use _FP_W_TYPE for frac
	bit-fields.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/ChangeLog.diff?cvsroot=glibc&r1=1.10562&r2=1.10563
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/soft-fp/double.h.diff?cvsroot=glibc&r1=1.7&r2=1.8
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/soft-fp/extended.h.diff?cvsroot=glibc&r1=1.7&r2=1.8
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/soft-fp/quad.h.diff?cvsroot=glibc&r1=1.8&r2=1.9
Comment 4 Jakub Jelinek 2007-03-26 13:04:09 UTC 
Fixed.