Bug 15575 - __tcp_sock_dport and __tcp_sock_sport should return host order
Summary: __tcp_sock_dport and __tcp_sock_sport should return host order
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
: 13702 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-06-05 01:20 UTC by Josh Stone
Modified: 2013-08-05 17:57 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Stone 2013-06-05 01:20:16 UTC 
The tapset functions __tcp_sock_dport and __tcp_sock_sport are returning their respective values as-is, which happens to be network order.  This is confusing for users; we ought to present host order instead.  This will also parallel the similar skb functions that already do ntohs().

Reported-by: "bcall" on freenode #systemtap
Comment 1 Josh Stone 2013-06-05 01:27:47 UTC 
commit db7b8b2ff97c6f532f5f2941ca25f1859a0fcdc8
Comment 2 David Smith 2013-08-05 17:57:07 UTC 
*** Bug 13702 has been marked as a duplicate of this bug. ***