Bug 1498 - Wrong result for some integer divisions on Alpha

Bug#:

1498 alias:

Hardware:

Reporter:

Falk Hueffner <falk@debian.org>

Host:

Target:

Build:

Product:

Add CC:

Component:

Version:

CC:

Remove selected CCs

Status:

RESOLVED

Priority:

Resolution:

FIXED

Severity:

Assigned To:

Roland McGrath <roland@gnu.org>

Target Milestone:

Flags:			Requestee:
	backport		()
	examined		()
	testsuite		()

Summary:

Keywords:

Attachment	Description	Type	Created	Actions
glibc235-alpha-divqu.patch	patch	patch	2005-10-18 20:47	Edit \| Diff
Create a New Attachment (proposed patch, testcase, etc.)			View All

Bug 1498 depends on:			Show dependency tree Show dependency graph
Bug 1498 blocks:	~~852~~		Show dependency tree Show dependency graph

Additional Comments:

Leave as RESOLVED FIXED
Reopen bug
Mark bug as VERIFIED

View Bug Activity | Format For Printing

Description:

Last confirmed: 0000-00-00 00:00

Opened: 2005-10-18 20:46

When x has bit 63 set, then the unsigned integer division x/x will give 0
instead of 1. This is due to a typo in __divqu. The same problem exists in 
__remqu. This breaks gmp (see http://bugs.debian.org/324455). The attached
patch fixes it. This patch has been in use in Debian's glibc for a while.

------- Additional Comment #1 From Falk Hueffner 2005-10-18 20:47 -------

Created an attachment (id=721)
patch

------- Additional Comment #2 From Richard Henderson 2005-10-18 20:58 -------

The patch is correct.  I asked Falk to open the PR for Roland and the 2.3 branch.

------- Additional Comment #3 From Ulrich Drepper 2005-10-20 05:25 -------

Fixed on the trunk.  Possibly for the 2.3 branch.

------- Additional Comment #4 From cvs-commit@gcc.gnu.org 2005-10-23 00:52 -------

Subject: Bug 1498

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-10-23 00:52:00

Modified files:
	sysdeps/alpha  : divqu.S remqu.S 

Log message:
	2005-08-23  GOTO Masanori  <gotom@debian.or.jp>
	
	[BZ #1498]
	* sysdeps/alpha/remqu.S: Return the correct result when the same
	dividend and divisor are provided, and they're negative numbers.
	* sysdeps/alpha/divqu.S: Likewise.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/alpha/divqu.S.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.8&r2=1.8.4.1
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/alpha/remqu.S.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.10&r2=1.10.4.1

------- Additional Comment #5 From GOTO Masanori 2005-10-29 05:47 -------

Thanks for your catching up to apply the patch.

------- Additional Comment #6 From Roland McGrath 2005-11-04 21:43 -------

This bug should be fixed in the 2.3.6 release just made.