Bug 14497 - declare short functions inline
Summary: declare short functions inline
Status: RESOLVED WONTFIX
Alias: None
Product: glibc
Classification: Unclassified
Component: libc (show other bugs)
Version: 2.16
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-19 10:21 UTC by wbrana
Modified: 2014-06-17 18:33 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description wbrana 2012-08-19 10:21:01 UTC 
short functions like fdatasync could be declared inline

int
fdatasync (int fildes)
{
  return fsync (fildes);
}
Comment 1 Andreas Jaeger 2012-11-16 11:06:03 UTC 
We do this already for functions where it is possible to do so and makes sense, e.g. for some math functions.

Such short functions need both an inline function as well as a real implementation.

fdatasync is in no way performance critical and the overhead of duplicating the function does not deserve this extra work.