Bug 13793 - IPv6 nfs_proc.stp tapset changes needed
Summary: IPv6 nfs_proc.stp tapset changes needed
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Alice Zhang
URL:
Keywords:
Depends on: 13646
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-01 17:28 UTC by David Smith
Modified: 2020-06-01 19:10 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
the patch related to changes that give nfs_proc IPv6 support (46 bytes, patch)
2020-06-01 18:56 UTC, Alice Zhang
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Smith 2012-03-01 17:28:14 UTC
The nfs_proc.stp tapset is full of probes that return 'server_ip', a binary IP address of the server.  A typical line to generate that value looks like this:

	server_ip = __i2n_ip_proto($dir,0)

That works fine for IPv4.  That binary value can be used in comparisons, as an array index, etc.  However, the above doesn't work for IPv6.  That function (if it supported IPv6) would return the address of a structure that holds the IPv6 address.

Those probes should be changed to return a string representation of the IP address, which can be compared properly for both IPv4 and IPv6.

(Bug #13646 provided the base tapset IPv6 support.)
Comment 1 Alice Zhang 2020-06-01 18:56:54 UTC
Created attachment 12578 [details]
the patch related to changes that give nfs_proc IPv6 support
Comment 2 Alice Zhang 2020-06-01 19:05:29 UTC
Commit d03599, eed54b and 506de2 are related updates for supporting IPv6.
With systemtap version <= 4.2, get_ip will work with only IPv4 and a long type will be returned for get_ip(); with version > 4.3, both IPv4 and IPv6 are supported while return type is String.
Comment 3 Alice Zhang 2020-06-01 19:08:29 UTC
Comment on attachment 12578 [details]
the patch related to changes that give nfs_proc IPv6 support

https://paste.centos.org/view/617b7556
Comment 4 Alice Zhang 2020-06-01 19:09:23 UTC
Comment on attachment 12578 [details]
the patch related to changes that give nfs_proc IPv6 support

https://paste.centos.org/view/617b7556
Comment 5 Alice Zhang 2020-06-01 19:10:08 UTC
Comment on attachment 12578 [details]
the patch related to changes that give nfs_proc IPv6 support

https://paste.centos.org/view/617b7556