Bug 13736 - prohibit --use-server=HOSTNAME without :PORT
Summary: prohibit --use-server=HOSTNAME without :PORT
Status: RESOLVED WORKSFORME
Alias: None
Product: systemtap
Classification: Unclassified
Component: server (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-23 22:14 UTC by Frank Ch. Eigler
Modified: 2012-03-26 19:21 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Ch. Eigler 2012-02-23 22:14:44 UTC
Without a given port number, without avahi, and without a IETF-assigned
port number, the stap-client is just guessing.  It should instead give up.
Comment 1 Dave Brolley 2012-03-07 19:58:15 UTC
I would like to argue to leave things as they are. Currently, the user can specify:

--use-server - the client uses avahi to find a suitable server on the local network.

--use-server=HOSTNAME - the client uses avahi to find a suitable server on the named host only

--use-server=HOSTNAME:PORT - the client contacts the specified server. Avahi is not required.

An IP address may be specified for HOSTNAME. 

The above applies to --use-server in conjunction with --list-servers and to --use-server when compiling a script (or both simultaneously).

--use-server=HOSTNAME is also useful in conjunction with --trust-servers for adding|removing trust in servers on a particular host.

When avahi is not present both --use-server and use-server=HOSTNAME will fail to find servers on the network, but could still find server certificates in NSS databases related to that host (useful when removing trust).

I see no reason to disable this useful functionality.
Comment 2 Frank Ch. Eigler 2012-03-07 20:29:19 UTC
> [...]
> --use-server=HOSTNAME - the client uses avahi to find a suitable server on the
> named host only
> [...]

Note that I was only talking about the non-avahi case.

> When avahi is not present both --use-server and use-server=HOSTNAME will fail
> to find servers on the network [...]

Definitely or only usually?  If the former, OK, let's leave it alone.
Comment 3 Frank Ch. Eigler 2012-03-26 16:45:07 UTC
> > When avahi is not present both --use-server and use-server=HOSTNAME will fail
> > to find servers on the network [...]
> 
> Definitely or only usually?  If the former, OK, let's leave it alone.

ping
Comment 4 Dave Brolley 2012-03-26 19:18:52 UTC
(In reply to comment #2)
> > [...]
> > --use-server=HOSTNAME - the client uses avahi to find a suitable server on the
> > named host only
> > [...]
> 
> Note that I was only talking about the non-avahi case.
> 
> > When avahi is not present both --use-server and use-server=HOSTNAME will fail
> > to find servers on the network [...]
> 
> Definitely or only usually?  If the former, OK, let's leave it alone.

Sorry. The answer is Definitely. OK to close>
Comment 5 Frank Ch. Eigler 2012-03-26 19:21:47 UTC
Thanks for the explanation.