Bug 11480 - bad kfail for rpc-all-probes.stp test
Summary: bad kfail for rpc-all-probes.stp test
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: David Smith
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-08 20:24 UTC by David Smith
Modified: 2010-04-16 14:19 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Smith 2010-04-08 20:24:43 UTC 
testsuite/systemtap.pass1-4/buildok.exp "kfails" (marks as a known failure)
buildok/rpc-all-probes.stp because of bug 4413.  While the rpc.stp tapset does
have at least one problem related to that bug, the real problems with the
rpc.stp tapset are due to not handling kernel changes correctly.

The "kfail" is hiding real problems with the rpc tapset.

For instance, the prototype of rpc_new_client() has changed from:

static struct rpc_clnt *
rpc_new_client(struct rpc_xprt *xprt, char *servname,
    struct rpc_program *program, u32 vers,
    rpc_authflavor_t flavor);

to:

static struct rpc_clnt *
rpc_new_client(const struct rpc_create_args *args, struct rpc_xprt *xprt);

But, the sunrpc.clnt.create_client probe is unaware of this change.

The buildok/rpc-all-probes.stp test needs to be unmarked as a 'kfail' (and
improved) and the rpc.stp tapset needs to be updated.
Comment 1 David Smith 2010-04-16 14:19:33 UTC 
Commit 9f61fc1 gets rpc.stp working on RHEL4 (2.6.9-89.0.20.EL), RHEL5
(2.6.18-186.el5), f12 (2.6.32.11-99.fc12.i686.PAE), and rawhide
(2.6.34-0.28.rc3.git3.fc14.x86_64).