2626 2006-05-01 09:07:00 +0000 Problems with LPM on attiny26 2008-02-14 13:04:50 +0000 1 1 1 Unclassified binutils gas 2.16 All All RESOLVED FIXED P2 normal --- 1 hakan unassigned bug-binutils eric.weddington joachim.falk i486-linux-gnu avr i486-linux-gnu oldest_to_newest 9865 0 hakan 2006-05-01 09:07:00 +0000 Forwarding debian bug #362270 from Terran Melconian <terran@consistent.org>: The attiny26 supports some forms of the LPM (load program memory) instruction, but under certain circumstances GAS produces an incorrect error claiming that it does not. There are three forms of the LPM instruction. They are: i. LPM (r0 is implied destination) ii. LPM destreg, Z iii. LPM destreg, Z+ (reference: Atmel AVR instruction set reference, revision 06/99, page 79) Of these, the attiny26 supports forms i and ii but not iii. (reference: Atmel attiny26 datasheet, revision 1477G 03/05, page 170) avr-as will assemble form i, but refuses to assemble forms ii or iii. Since the datasheet states that form ii *is* supported on this part, I believe this to be a bug. Of course it is possible that it is an error in the manufacturer's datasheet, and that as' behavior is in fact correct, but barring explicit information to the contrary I must assume that the manufacturer's datasheet is authoritative. 21542 1 2236 joachim.falk 2008-02-06 20:42:58 +0000 Created attachment 2236 The FIX. Patch is against GNU assembler 2.17.50 20060817 Debian GNU/Linux + coff-avr-patch (20050630) The bugfix has been tested with attiny26 and attiny2313. Where gas now allows lpm r,z for attiny26 but generates "xxx.S:Nr: Error: postincrement not supported" errors for lpm r,z+. As before attiny2313 allow both forms of the lpm instruction. Cheers, Joachim Falk 21667 2 nickc 2008-02-14 13:04:50 +0000 Hi Hakan, Thanks for submitting this fix. I have applied it along with these changelog entries. Cheers Nick include/opcode/ChangeLog 2008-02-14 Hakan Ardo <hakan@debian.org> PR gas/2626 * avr.h (AVR_ISA_2xxe): Define. gas/ChangeLog 2008-02-14 Hakan Ardo <hakan@debian.org> PR gas/2626 * config/tc-avr.c (mcu_types): Change the ISA tyoe of the attiny26 to AVR_ISA_2xxe. (avr_operand): Disallow post-increment addressing in the lpm instruction for the attiny26. 21669 3 hakan 2008-02-14 15:10:40 +0000 Subject: Re: Problems with LPM on attiny26 Hi, I only forwarded this bugrepport from the debian bts, the fix was done (as far as I can tell) by joachim dot falk at gmx dot de, and you should probably contribute it to him and not to me. On 14 Feb 2008 13:04:51 -0000, nickc at redhat dot com <sourceware-bugzilla@sourceware.org> wrote: > > ------- Additional Comments From nickc at redhat dot com 2008-02-14 13:04 ------- > Hi Hakan, > > Thanks for submitting this fix. I have applied it along with these changelog > entries. > > Cheers > Nick > > include/opcode/ChangeLog > 2008-02-14 Hakan Ardo <hakan@debian.org> > > PR gas/2626 > * avr.h (AVR_ISA_2xxe): Define. > > gas/ChangeLog > 2008-02-14 Hakan Ardo <hakan@debian.org> > > PR gas/2626 > * config/tc-avr.c (mcu_types): Change the ISA tyoe of the attiny26 > to AVR_ISA_2xxe. > (avr_operand): Disallow post-increment addressing in the lpm > instruction for the attiny26. > > > -- > What |Removed |Added > ---------------------------------------------------------------------------- > Status|WAITING |RESOLVED > Resolution| |FIXED > > > > > http://sourceware.org/bugzilla/show_bug.cgi?id=2626 > > ------- You are receiving this mail because: ------- > You reported the bug, or are watching the reporter. > 2236 2008-02-06 20:42:00 +0000 2008-02-06 20:42:58 +0000 The FIX. Patch is against GNU assembler 2.17.50 20060817 Debian GNU/Linux + coff-avr-patch (20050630) 970-binutils-20060817-avr-attiny26-lpm.patch text/plain 1622 joachim.falk LS0tIGJpbnV0aWxzLTIwMDYwODE3LTEvaW5jbHVkZS9vcGNvZGUvYXZyLmgub3JpZwkyMDA4LTAy LTA2IDEzOjAwOjE3LjAwMDAwMDAwMCArMDEwMAorKysgYmludXRpbHMtMjAwNjA4MTctMS9pbmNs dWRlL29wY29kZS9hdnIuaAkyMDA4LTAyLTA2IDE5OjA4OjE2LjAwMDAwMDAwMCArMDEwMApAQCAt MzQsNiArMzQsOCBAQAogI2RlZmluZSBBVlJfSVNBX1RJTlkxIChBVlJfSVNBXzEyMDAgfCBBVlJf SVNBX0xQTSkKICNkZWZpbmUgQVZSX0lTQV9QV014ICAoQVZSX0lTQV9NOCAgIHwgQVZSX0lTQV9C UkspCiAjZGVmaW5lIEFWUl9JU0FfMnh4eCAgKEFWUl9JU0FfVElOWTEgfCBBVlJfSVNBX1NSQU0p CisvKiBTcGVjaWFsIGhhY2sgaW4gdGMtYXZyLmMgYXR0aW55MjYgaXMgbWlzc2luZyBMUE0gUmQs WisgKi8KKyNkZWZpbmUgQVZSX0lTQV8yeHhlICAoQVZSX0lTQV8yeHh4IHwgQVZSX0lTQV9MUE1Y KQogI2RlZmluZSBBVlJfSVNBX1RJTlkyIChBVlJfSVNBXzJ4eHggfCBBVlJfSVNBX01PVlcgfCBB VlJfSVNBX0xQTVggfCBcCiAgICAgICAgICAgICAgICAgICAgICAgIEFWUl9JU0FfU1BNICB8IEFW Ul9JU0FfQlJLKQogI2RlZmluZSBBVlJfSVNBX004ICAgIChBVlJfSVNBXzJ4eHggfCBBVlJfSVNB X01VTCB8IEFWUl9JU0FfTU9WVyB8IFwKLS0tIGJpbnV0aWxzLTIwMDYwODE3LTEvZ2FzL2NvbmZp Zy90Yy1hdnIuYy5vcmlnCTIwMDgtMDItMDYgMTI6NTY6MTguMDAwMDAwMDAwICswMTAwCisrKyBi aW51dGlscy0yMDA2MDgxNy0xL2dhcy9jb25maWcvdGMtYXZyLmMJMjAwOC0wMi0wNiAxOTowNToy My4wMDAwMDAwMDAgKzAxMDAKQEAgLTc4LDcgKzc4LDcgQEAKICAgeyJhdDkwczIzMzMiLCAgQVZS X0lTQV8yeHh4LCAgICBiZmRfbWFjaF9hdnIyfSwgLyogWFhYIC0+IDQ0MzMgKi8KICAgeyJhdDkw czIzNDMiLCAgQVZSX0lTQV8yeHh4LCAgICBiZmRfbWFjaF9hdnIyfSwKICAgeyJhdHRpbnkyMiIs ICAgQVZSX0lTQV8yeHh4LCAgICBiZmRfbWFjaF9hdnIyfSwgLyogWFhYIC0+IDIzNDMgKi8KLSAg eyJhdHRpbnkyNiIsICAgQVZSX0lTQV8yeHh4LCAgICBiZmRfbWFjaF9hdnIyfSwKKyAgeyJhdHRp bnkyNiIsICAgQVZSX0lTQV8yeHhlLCAgICBiZmRfbWFjaF9hdnIyfSwKICAgeyJhdDkwczQ0MzMi LCAgQVZSX0lTQV8yeHh4LCAgICBiZmRfbWFjaF9hdnIyfSwKICAgeyJhdDkwczQ0MTQiLCAgQVZS X0lTQV8yeHh4LCAgICBiZmRfbWFjaF9hdnIyfSwgLyogWFhYIC0+IDg1MTUgKi8KICAgeyJhdDkw czQ0MzQiLCAgQVZSX0lTQV8yeHh4LCAgICBiZmRfbWFjaF9hdnIyfSwgLyogWFhYIC0+IDg1MzUg Ki8KQEAgLTc5Miw2ICs3OTIsMTAgQEAKIAkgICsrc3RyOwogCSAgb3BfbWFzayB8PSAxOwogCX0K KyAgICAgIC8qIGF0dGlueTI2IGNhbiBkbyAibHBtIiBhbmQgImxwbSByLFoiIGJ1dCBubyBwb3N0 aW5jcmVtZW50LiAqLworICAgICAgaWYgKCFhdnJfb3B0LmFsbF9vcGNvZGVzICYmIChvcF9tYXNr ICYgMHgwMDAxKQorICAgICAgICAgICYmICEoYXZyX21jdS0+aXNhICYgQVZSX0lTQV9NT1ZXKSkK KyAgICAgICAgYXNfYmFkIChfKCJwb3N0aW5jcmVtZW50IG5vdCBzdXBwb3J0ZWQiKSk7CiAgICAg ICBicmVhazsKIAogICAgIGNhc2UgJ2InOgo=