<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://sourceware.org/bugzilla/bugzilla.dtd">

<bugzilla version="4.0.10"
          urlbase="http://sourceware.org/bugzilla/"
          
          maintainer="overseers@sourceware.org"
>

    <bug>
          <bug_id>10997</bug_id>
          
          <creation_ts>2009-11-22 14:30:00 +0000</creation_ts>
          <short_desc>Xserver segfaults when Composite used</short_desc>
          <delta_ts>2010-02-19 19:20:07 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>cygwin</product>
          <component>Cygwin/X</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jon TURNEY">jon.turney</reporter>
          <assigned_to name="Cygwin/X maintainer">yselkowitz</assigned_to>
          
          <cf_gcchost></cf_gcchost>
          <cf_gcctarget></cf_gcctarget>
          <cf_gccbuild></cf_gccbuild>
          

      

      

      

          <long_desc isprivate="0">
            <commentid>39980</commentid>
            <who name="Jon TURNEY">jon.turney</who>
            <bug_when>2009-11-22 14:30:06 +0000</bug_when>
            <thetext>A few reports of Xserver segfaults when using a XDMCP session to Fedora 12
(Constantine) and Ubuntu 9.10 (Karmic)

http://cygwin.com/ml/cygwin-xfree/2009-11/msg00152.html
http://cygwin.com/ml/cygwin-xfree/2009-11/msg00000.html

This seems to be due to a bad interaction between the damage tracking for the
Composite extension and damage tracking for the shadow framebuffer.

Where I have been able to reproduce the problem, disabling the composite
extension with &apos;-extension Composite&apos; works around it.

It&apos;s not clear why this hasn&apos;t bitten us before: nothing obviously relevant has
changed in Xserver 1.7, but maybe we were just lucky, or it may be that Gnome in
recent linux distros makes more extensive use of composite which tickles the bug.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>39981</commentid>
            <who name="Jon TURNEY">jon.turney</who>
            <bug_when>2009-11-22 14:31:35 +0000</bug_when>
            <thetext>Possibly relevant upstream report:

http://lists.freedesktop.org/archives/xorg/2005-September/010150.html</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>39982</commentid>
            <who name="Jon TURNEY">jon.turney</who>
            <bug_when>2009-11-22 14:32:24 +0000</bug_when>
            <thetext>
A simple way to demonstrate this problem:
- start xserver
- start xcompmgr
- start xterm
- exit xterm
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>39983</commentid>
              <attachid>4405</attachid>
            <who name="Jon TURNEY">jon.turney</who>
            <bug_when>2009-11-22 14:55:51 +0000</bug_when>
            <thetext>Created attachment 4405
Patch to disable composite extension by default

This looks like a fairly complex problem to solve, so perhaps as an interim
measure disable compsite by default to stop XDMCP users tripping over this
issue.

We did discuss this back at
http://sourceforge.net/mailarchive/forum.php?thread_name=4908A723.10405%40users.sourceforge.net&amp;forum_name=cygwin-ports-general


Updated patch attached</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>40033</commentid>
            <who name="Cygwin/X maintainer">yselkowitz</who>
            <bug_when>2009-11-24 02:40:58 +0000</bug_when>
            <thetext>Might this be related?

http://bugs.freedesktop.org/show_bug.cgi?id=25136
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>40358</commentid>
            <who name="Cygwin/X maintainer">yselkowitz</who>
            <bug_when>2009-12-14 04:11:27 +0000</bug_when>
            <thetext>Confirmed.  Composite was working fine before, so this is clearly a change in the 
server.

I suspect Keith&apos;s 6 patches in master (d3e054a..a72c65e) may fix this, but they 
haven&apos;t been backported to 1.7 yet.  In the meantime, as this appears to be 
completely broken, I&apos;ll just disable the Composite extension entirely in 
configure.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>40448</commentid>
            <who name="Cygwin/X maintainer">yselkowitz</who>
            <bug_when>2009-12-21 03:17:51 +0000</bug_when>
            <thetext>Unfortunately the backported fb patch posted to xorg-devel today doesn&apos;t help. 
:-(

FWIW, here&apos;s a backtrace of the crash:

0x004cfaf0 in damageRegionAppend (pDrawable=0x1919560, pRegion=0x28cb48,
    clip=1, subWindowMode=1)
    at miext/damage/damage.c:290
290             if (pDamage-&gt;pDrawable-&gt;type == DRAWABLE_WINDOW &amp;&amp;
(gdb) bt
#0  0x004cfaf0 in damageRegionAppend (pDrawable=0x1919560, pRegion=0x28cb48,
    clip=1, subWindowMode=1)
    at miext/damage/damage.c:290
#1  0x004cfd81 in damageDamageBox (pDrawable=0x1919560,
    pBox=&lt;value optimized out&gt;, subWindowMode=&lt;value optimized out&gt;)
    at miext/damage/damage.c:425
#2  0x004d0334 in damageComposite (op=1 &apos;\001&apos;, pSrc=0x1dfefb8, pMask=0x0,
    pDst=0x1dfe970, xSrc=0, ySrc=0, xMask=0, yMask=0, xDst=0, yDst=0,
    width=1394, height=992)
    at miext/damage/damage.c:640
#3  0x00466fc1 in ProcRenderComposite (client=0x1db6830)
    at render/render.c:723
#4  0x004f05d6 in Dispatch ()
    at dix/dispatch.c:445
#5  0x004e56aa in main (argc=1, argv=0x18b9ba0, envp=0xffffffff)
    at dix/main.c:285
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>41404</commentid>
              <attachid>4580</attachid>
            <who name="Jon TURNEY">jon.turney</who>
            <bug_when>2010-02-08 21:44:37 +0000</bug_when>
            <thetext>Created attachment 4580
Don&apos;t enable ROOTLESS_WORKAROUND, it breaks Composite</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>41426</commentid>
            <who name="Cygwin/X maintainer">yselkowitz</who>
            <bug_when>2010-02-09 20:40:20 +0000</bug_when>
            <thetext>Nice work.  Whether that opens up to http://bugs.freedesktop.org/show_bug.cgi?
id=1168 will have to be seen, but this would only affect WindowsWM, so I&apos;m not 
overly concerned.

Patch in queue for 1.7.4.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>41595</commentid>
            <who name="Cygwin/X maintainer">yselkowitz</who>
            <bug_when>2010-02-19 19:20:07 +0000</bug_when>
            <thetext>WFM and at least one other person on the list.  Patch committed and cherry-picked; 
closing.</thetext>
          </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
              isurl="0"
          >
            <attachid>4405</attachid>
            <date>2009-11-22 14:55:00 +0000</date>
            <delta_ts>2010-02-08 21:44:38 +0000</delta_ts>
            <desc>Patch to disable composite extension by default</desc>
            <filename>0001-Disable-composite-by-default.patch</filename>
            <type>text/plain</type>
            <size>654</size>
            <attacher>jon.turney</attacher>
            
              <data encoding="base64">RnJvbSBmODMwZjU2YzAyODU3ZDZhNWUxZjhjMTE3YjEwZDRlYzE3ZWQyMjZiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVFVSTkVZIDxqb24udHVybmV5QGRyb25lY29kZS5vcmcu
dWs+CkRhdGU6IFN1biwgMjIgTm92IDIwMDkgMTQ6NTI6MTMgKzAwMDAKU3ViamVjdDogW1BBVENI
XSBEaXNhYmxlIGNvbXBvc2l0ZSBieSBkZWZhdWx0CgpTaWduZWQtb2ZmLWJ5OiBKb24gVFVSTkVZ
IDxqb24udHVybmV5QGRyb25lY29kZS5vcmcudWs+Ci0tLQogb3MvdXRpbHMuYyB8ICAgIDIgKy0K
IDEgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAt
LWdpdCBhL29zL3V0aWxzLmMgYi9vcy91dGlscy5jCmluZGV4IGQ5NDQwOGEuLjM4Nzk0NDkgMTAw
NjQ0Ci0tLSBhL29zL3V0aWxzLmMKKysrIGIvb3MvdXRpbHMuYwpAQCAtMTI2LDcgKzEyNiw3IEBA
IF9fc3RkY2FsbCB1bnNpZ25lZCBsb25nIEdldFRpY2tDb3VudCh2b2lkKTsKIAogQm9vbCBub1Rl
c3RFeHRlbnNpb25zOwogI2lmZGVmIENPTVBPU0lURQotQm9vbCBub0NvbXBvc2l0ZUV4dGVuc2lv
biA9IEZBTFNFOworQm9vbCBub0NvbXBvc2l0ZUV4dGVuc2lvbiA9IFRSVUU7CiAjZW5kaWYKIAog
I2lmZGVmIERBTUFHRQotLSAKMS42LjQuMgoK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
              isurl="0"
          >
            <attachid>4580</attachid>
            <date>2010-02-08 21:44:00 +0000</date>
            <delta_ts>2010-02-08 21:44:37 +0000</delta_ts>
            <desc>Don&apos;t enable ROOTLESS_WORKAROUND, it breaks Composite</desc>
            <filename>0001-Don-t-enable-ROOTLESS_WORKAROUND-it-breaks-composite.patch</filename>
            <type>text/plain</type>
            <size>1005</size>
            <attacher>jon.turney</attacher>
            
              <data encoding="base64">RnJvbSAxOTE0NTcyZGUwOTM0ZGVhNDNhYTBmNmE0ZTQxZGY5M2EyMzIyYTU0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVFVSTkVZIDxqb24udHVybmV5QGRyb25lY29kZS5vcmcu
dWs+CkRhdGU6IE1vbiwgOCBGZWIgMjAxMCAyMTozOToyNSArMDAwMApTdWJqZWN0OiBbUEFUQ0hd
IERvbid0IGVuYWJsZSBST09UTEVTU19XT1JLQVJPVU5ELCBpdCBicmVha3MgY29tcG9zaXRlCgpU
aGlzIHBvc3NpYmx5IGJyaW5ncyBiYWNrIHdoYXRldmVyIHRoZSBidWcgaXMgaW4KaHR0cDovL2J1
Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY4IGZvcgotcm9vdGxlc3MgbW9k
ZSwgYnV0IHNpbmNlIHdlIGRvbid0IGhhdmUgcmVwcm9kdWN0aW9uCnN0ZXBzIGZvciB0aGF0LCBJ
IGNhbid0IHRlc3QgdGhhdC4uLgoKU2lnbmVkLW9mZi1ieTogSm9uIFRVUk5FWSA8am9uLnR1cm5l
eUBkcm9uZWNvZGUub3JnLnVrPgotLS0KIGNvbmZpZ3VyZS5hYyB8ICAgIDEgLQogMSBmaWxlcyBj
aGFuZ2VkLCAwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvY29u
ZmlndXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IGVjOTQ0MmIuLmEyY2IzODIgMTAwNjQ0Ci0t
LSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTE4MzYsNyArMTgzNiw2IEBA
IGlmIHRlc3QgIngkWFdJTiIgPSB4eWVzOyB0aGVuCiAJCQlkbmwgaWYgd2UgaGF2ZSB3aW5kb3dz
d21wcm90bywgYnVpbGQgcm9vdGxlc3MgZXh0ZW5zaW9uIGZvciBtdWx0d2luZG93ZXh0d20gbW9k
ZQogCQkJaWYgdGVzdCAieCRXSU5ET1dTV00iID0geHllcyA7IHRoZW4KIAkJCSAgICAgICBBQ19E
RUZJTkUoUk9PVExFU1MsMSxbQnVpbGQgUm9vdGxlc3MgY29kZV0pCi0JCQkgICAgICAgQ0ZMQUdT
PSIkQ0ZMQUdTIC1EUk9PVExFU1NfV09SS0FST1VORCIKIAkJCWZpCiAKIAkJCUNGTEFHUz0iJENG
TEFHUyAtREZEX1NFVFNJWkU9MjU2IgotLSAKMS42LjYuMQoK
</data>

          </attachment>
      

    </bug>

</bugzilla>