10549 2009-08-22 16:40:00 +0000 gas doesn't provide correct ELF ABI for object with unique symbols 2011-04-27 07:43:30 +0000 1 1 1 Unclassified binutils gas 2.20 All All RESOLVED FIXED P2 normal --- 1 drepper.fsp unassigned amodra bug-binutils mjw 37861 drepper.fsp 2009-08-22 16:40:30 +0000 Assemble this file .type a, @gnu_unique_object a: .long 0 .size a, .-a and the result will have on Linux/x86-64 a header which has an ELF header with no special OSABI marker. But STB_GNU_UNIQUE requires that. gas should also notice the STB_GNU_UNIQUE binding and change the OSABI to ELFOSABI_LINUX, just as ld does. 37887 4149 nickc 2009-08-25 10:01:54 +0000 Created attachment 4149 Set elf_osabi field when processing a gnu_unique_object 37888 nickc 2009-08-25 10:03:46 +0000 Hi Uli, The uploaded patch should do what you want. But - are you sure that the linker is setting the ELFOSABI field to ELFOSABI_LINUX for binaries containing STB_GBU_UNIQUE symbols ? In my tests it did not (and just left the field as ELFOSABI_NONE). Cheers Nick 48148 mjw 2011-04-07 20:03:00 +0000 Posted a patch for the ld part: http://sourceware.org/ml/binutils/2011-04/msg00107.html 48192 cvs-commit 2011-04-11 08:13:26 +0000 CVSROOT: /cvs/src Module name: src Changes by: nickc@sourceware.org 2011-04-11 08:13:22 Modified files: bfd : ChangeLog elf-bfd.h elf.c elf32-arm.c elf32-i386.c elf32-ppc.c elf32-sparc.c elf64-ppc.c elf64-sparc.c elf64-x86-64.c ld/testsuite : ChangeLog Added files: ld/testsuite/ld-unique: unique.exp unique.s unique_empty.s unique_shared.s Log message: PR 10549 * elf-bfd.h (has_ifunc_symbols): Renamed to has_gnu_symbols. (has_gnu_symbols): Renamed from has_ifunc_symbols. * elf.c (_bfd_elf_set_osabi): Use new has_gnu_symbols name. * elf32-arm.c (elf32_arm_add_symbol_hook): Set has_gnu_symbols also if STB_GNU_UNIQUE symbol binding was seen. * elf32-i386.c (elf_i386_add_symbol_hook): Likewise. * elf32-ppc.c (ppc_elf_add_symbol_hook): Likewise. * elf32-sparc.c (elf32_sparc_add_symbol_hook): Likewise. * elf64-ppc.c (ppc64_elf_add_symbol_hook): Likewise. * elf64-sparc.c (elf64_sparc_add_symbol_hook): Likewise. * elf64-x86-64.c (elf_x86_64_add_symbol_hook): Likewise. * ld-unique: New directory. * ld-unique/unique.exp: New file: Run the UNIQUE tests. * ld-unique/unique.s: New test file. * ld-unique/unique_empty.s: Likewise. * ld-unique/unique_shared.s: Likewise. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=src&r1=1.5300&r2=1.5301 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf-bfd.h.diff?cvsroot=src&r1=1.315&r2=1.316 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf.c.diff?cvsroot=src&r1=1.530&r2=1.531 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-arm.c.diff?cvsroot=src&r1=1.262&r2=1.263 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-i386.c.diff?cvsroot=src&r1=1.246&r2=1.247 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-ppc.c.diff?cvsroot=src&r1=1.292&r2=1.293 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-sparc.c.diff?cvsroot=src&r1=1.94&r2=1.95 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-ppc.c.diff?cvsroot=src&r1=1.346&r2=1.347 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-sparc.c.diff?cvsroot=src&r1=1.125&r2=1.126 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-x86-64.c.diff?cvsroot=src&r1=1.219&r2=1.220 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1384&r2=1.1385 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-unique/unique.exp.diff?cvsroot=src&r1=NONE&r2=1.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-unique/unique.s.diff?cvsroot=src&r1=NONE&r2=1.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-unique/unique_empty.s.diff?cvsroot=src&r1=NONE&r2=1.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-unique/unique_shared.s.diff?cvsroot=src&r1=NONE&r2=1.1 48391 cvs-commit 2011-04-27 07:17:52 +0000 CVSROOT: /cvs/src Module name: src Branch: binutils-2_21-branch Changes by: amodra@sourceware.org 2011-04-27 07:17:45 Modified files: bfd : ChangeLog bfd-in2.h bfd.c coff-aux.c elf-bfd.h elf.c elf32-i386.c elf32-ppc.c elf32-sparc.c elf64-ppc.c elf64-sparc.c elf64-x86-64.c elfcode.h elflink.c linker.c opncls.c plugin.c simple.c xcofflink.c gas/testsuite : ChangeLog gas/testsuite/gas/elf: elf.exp include : ChangeLog bfdlink.h ld : ChangeLog ld.texinfo ldfile.c ldlang.c ldlang.h ldmain.c lexsup.c plugin.c plugin.h ld/testsuite : ChangeLog ld/testsuite/ld-plugin: plugin-7.d plugin-8.d plugin.exp Added files: gas/testsuite/gas/elf: section9.d section9.s ld/testsuite/ld-plugin: plugin-12.d ld/testsuite/ld-unique: unique.exp unique.s unique_empty.s unique_shared.s Log message: PR ld/12696 PR ld/12672 PR ld/12507 PR ld/12365 PR 10549 Backport fixes for these PRs. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.5180.2.26&r2=1.5180.2.27 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfd-in2.h.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.522.2.1&r2=1.522.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfd.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.114.2.1&r2=1.114.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/coff-aux.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.10&r2=1.10.10.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf-bfd.h.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.313.2.1&r2=1.313.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.524.2.1&r2=1.524.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-i386.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.241&r2=1.241.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-ppc.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.290.2.2&r2=1.290.2.3 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-sparc.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.94&r2=1.94.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-ppc.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.339.2.7&r2=1.339.2.8 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-sparc.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.124&r2=1.124.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-x86-64.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.202&r2=1.202.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elfcode.h.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.103&r2=1.103.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elflink.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.388.2.1&r2=1.388.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/linker.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.77.2.1&r2=1.77.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/opncls.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.66&r2=1.66.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/plugin.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.9.2.1&r2=1.9.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/simple.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.34&r2=1.34.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/xcofflink.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.76.2.1&r2=1.76.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.1802.2.8&r2=1.1802.2.9 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/elf/section9.d.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=NONE&r2=1.1.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/elf/section9.s.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=NONE&r2=1.1.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/elf/elf.exp.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.69.2.1&r2=1.69.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.510.2.1&r2=1.510.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/bfdlink.h.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.82&r2=1.82.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.2222.2.18&r2=1.2222.2.19 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ld.texinfo.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.267.2.1&r2=1.267.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldfile.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.58.2.1&r2=1.58.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldlang.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.347.2.2&r2=1.347.2.3 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldlang.h.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.91.2.1&r2=1.91.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldmain.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.145.2.2&r2=1.145.2.3 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/lexsup.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.120.2.1&r2=1.120.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.c.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.7.2.3&r2=1.7.2.4 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.h.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.2.2.2&r2=1.2.2.3 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.1322.2.8&r2=1.1322.2.9 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-12.d.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=NONE&r2=1.1.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-7.d.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.1&r2=1.1.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-8.d.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.1&r2=1.1.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin.exp.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=1.5&r2=1.5.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-unique/unique.exp.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=NONE&r2=1.1.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-unique/unique.s.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=NONE&r2=1.1.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-unique/unique_empty.s.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=NONE&r2=1.1.2.1 http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-unique/unique_shared.s.diff?cvsroot=src&only_with_tag=binutils-2_21-branch&r1=NONE&r2=1.1.2.1 48395 amodra 2011-04-27 07:43:30 +0000 Fixed mainline and branch, except for arm on the 2.21 branch where ifunc support was missing. 4149 2009-08-25 10:01:00 +0000 2009-08-25 10:01:54 +0000 Set elf_osabi field when processing a gnu_unique_object pr10549_obj-elf.c_patch text/plain 1676 nickc SW5kZXg6IGdhcy9jb25maWcvb2JqLWVsZi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3Jj L3NyYy9nYXMvY29uZmlnL29iai1lbGYuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMTgKZGlm ZiAtYyAtMyAtcCAtcjEuMTE4IG9iai1lbGYuYwoqKiogZ2FzL2NvbmZpZy9vYmotZWxmLmMJMzEg SnVsIDIwMDkgMTg6MTQ6MDYgLTAwMDAJMS4xMTgKLS0tIGdhcy9jb25maWcvb2JqLWVsZi5jCTI1 IEF1ZyAyMDA5IDA5OjU4OjEwIC0wMDAwCioqKioqKioqKioqKioqKiBvYmpfZWxmX3R5cGUgKGlu dCBpZ25vcmUgQVRUUklCVVRFX1VOVVNFCioqKiAxNjkxLDE3MDUgKioqKgogICAgICB9CiAgICBl bHNlIGlmIChzdHJjbXAgKHR5cGVuYW1lLCAiZ251X3VuaXF1ZV9vYmplY3QiKSA9PSAwKQogICAg ICB7CiEgICAgICAgY29uc3Qgc3RydWN0IGVsZl9iYWNrZW5kX2RhdGEgKmJlZDsKICAKISAgICAg ICBiZWQgPSBnZXRfZWxmX2JhY2tlbmRfZGF0YSAoc3Rkb3V0cHV0KTsKICAgICAgICBpZiAoIShi ZWQtPmVsZl9vc2FiaSA9PSBFTEZPU0FCSV9MSU5VWAogIAkgICAgLyogR05VL0xpbnV4IGlzIHN0 aWxsIHVzaW5nIHRoZSBkZWZhdWx0IHZhbHVlIDAuICAqLwogIAkgICAgfHwgYmVkLT5lbGZfb3Nh YmkgPT0gRUxGT1NBQklfTk9ORSkpCiAgCWFzX2JhZCAoXygic3ltYm9sIHR5cGUgXCIlc1wiIGlz IHN1cHBvcnRlZCBvbmx5IGJ5IEdOVSB0YXJnZXRzIiksCiAgCQl0eXBlbmFtZSk7CiAgICAgICAg dHlwZSA9IEJTRl9PQkpFQ1QgfCBCU0ZfR05VX1VOSVFVRTsKICAgICAgfQogICNpZmRlZiBtZF9l bGZfc3ltYm9sX3R5cGUKICAgIGVsc2UgaWYgKCh0eXBlID0gbWRfZWxmX3N5bWJvbF90eXBlICh0 eXBlbmFtZSwgc3ltLCBlbGZzeW0pKSAhPSAtMSkKLS0tIDE2OTEsMTcwNyAtLS0tCiAgICAgIH0K ICAgIGVsc2UgaWYgKHN0cmNtcCAodHlwZW5hbWUsICJnbnVfdW5pcXVlX29iamVjdCIpID09IDAp CiAgICAgIHsKISAgICAgICBzdHJ1Y3QgZWxmX2JhY2tlbmRfZGF0YSAqYmVkOwogIAohICAgICAg IGJlZCA9IChzdHJ1Y3QgZWxmX2JhY2tlbmRfZGF0YSAqKSBnZXRfZWxmX2JhY2tlbmRfZGF0YSAo c3Rkb3V0cHV0KTsKICAgICAgICBpZiAoIShiZWQtPmVsZl9vc2FiaSA9PSBFTEZPU0FCSV9MSU5V WAogIAkgICAgLyogR05VL0xpbnV4IGlzIHN0aWxsIHVzaW5nIHRoZSBkZWZhdWx0IHZhbHVlIDAu ICAqLwogIAkgICAgfHwgYmVkLT5lbGZfb3NhYmkgPT0gRUxGT1NBQklfTk9ORSkpCiAgCWFzX2Jh ZCAoXygic3ltYm9sIHR5cGUgXCIlc1wiIGlzIHN1cHBvcnRlZCBvbmx5IGJ5IEdOVSB0YXJnZXRz IiksCiAgCQl0eXBlbmFtZSk7CiAgICAgICAgdHlwZSA9IEJTRl9PQkpFQ1QgfCBCU0ZfR05VX1VO SVFVRTsKKyAgICAgICAvKiBQUiAxMDU0OTogQWx3YXlzIHNldCBPU0FCSSBmaWVsZCB0byBMSU5V WCBmb3Igb2JqZWN0cyBjb250YWluaW5nIHVuaXF1ZSBzeW1ib2xzLiAgKi8KKyAgICAgICBiZWQt PmVsZl9vc2FiaSA9IEVMRk9TQUJJX0xJTlVYOwogICAgICB9CiAgI2lmZGVmIG1kX2VsZl9zeW1i b2xfdHlwZQogICAgZWxzZSBpZiAoKHR5cGUgPSBtZF9lbGZfc3ltYm9sX3R5cGUgKHR5cGVuYW1l LCBzeW0sIGVsZnN5bSkpICE9IC0xKQo=