10351 2009-06-30 16:58:00 +0000 Use a login bash shell to execute commands started from the tray menu 2009-10-13 05:03:26 +0000 1 1 1 Unclassified cygwin Cygwin/X unspecified All All RESOLVED FIXED P2 normal --- 1 jon.turney yselkowitz 36958 jon.turney 2009-06-30 16:58:10 +0000 Following discussion at http://cygwin.com/ml/cygwin-xfree/2009-06/msg00010.html, change to using a login bash shell to execute the commands started from the tray menu 36959 4031 jon.turney 2009-06-30 16:58:57 +0000 Created attachment 4031 Patch to use login bash shell for tray menu commands 36999 yselkowitz 2009-07-02 18:08:19 +0000 Thanks; patch added to the queue for the next release. 37070 yselkowitz 2009-07-08 23:29:50 +0000 Shipped in 1.6.2-1; closing. 38074 yselkowitz 2009-09-04 08:23:21 +0000 Trying the tray menu for the first time in a while, I see that using a login shell is expensive in terms of launch times. If I understand the thread correctly, the problem is only if XWin is launched directly from Windows. Maybe startxwin.{bat,sh} should launch XWin via "bash -l -c" instead, so the environment initialization need occur only once? 38560 4237 yselkowitz 2009-09-30 17:22:09 +0000 Created attachment 4237 patch for ports/xorg/xinit Here is what I am thinking for this bug and bug 10598. Can we use this instead, and revert the patch to xserver? 38564 jon.turney 2009-09-30 20:24:23 +0000 (In reply to comment #5) > Created an attachment (id=4237) > patch for ports/xorg/xinit > > Here is what I am thinking for this bug and bug 10598. Can we use this > instead, and revert the patch to xserver? Looks good to me. Don't forget that this adds run2 to the dependencies for xinit 38565 yselkowitz 2009-09-30 20:29:28 +0000 (In reply to comment #6) > Looks good to me. > > Don't forget that this adds run2 to the dependencies for xinit That means we depend on both run and run2. Unfortunately run2 is not a drop-in replacement for run (run2 uses XML files instead of command-line arguments), so we'll have to live with that for now. 38566 yselkowitz 2009-09-30 20:36:09 +0000 While I'm at it, I noticed that startxwin.sh (but not the .bat) contains: rm -rf /tmp/.X11-unix Doing that while another XWin display is running is a bad idea. e.g. I use :1 for multiwindow, leaving :0 open for startx launching, and testing startxwin.sh causes clients to be unable to connect to my :1 since the socket no longer exists. I'm going to change that to: rm -f /tmp/.X11-unix/X0 Just like in the .bat, since we explicitly set DISPLAY=127.0.0.1:0.0 earlier in the script. 38577 yselkowitz 2009-10-01 04:19:07 +0000 Shipped in xinit-1.1.1-5 and xorg-server-1.6.4-1; closing. 38632 4253 jon.turney 2009-10-04 14:59:21 +0000 Created attachment 4253 Tidy ups for system.Xwinrc Dropping this patch has dropped some tiding up in system.Xwinrc; here's a respun patch with just that in it... http://cygwin.com/ml/cygwin-xfree/2009-10/msg00023.html 38636 jon.turney 2009-10-04 21:22:44 +0000 Oh, and xterm started from the tray menu doesn't seem to inherit the correct environment :-( 38637 jon.turney 2009-10-04 22:02:08 +0000 (In reply to comment #11) > Oh, and xterm started from the tray menu doesn't seem to inherit the correct > environment :-( Hmm.. mysterious: comparing the output of running 'C:\cygwin\bin\run bash -l -c "env | sort >/tmp/env"' in a DOS shell, and "env | sort >/tmp/Xenv" from system.Xwinrc, the only significant difference seems to be PS1... 38676 yselkowitz 2009-10-07 01:33:24 +0000 (In reply to comment #10) > Created an attachment (id=4253) > Tidy ups for system.Xwinrc > > Dropping this patch has dropped some tiding up in system.Xwinrc; here's a > respun patch with just that in it... FWIW, the default fd.o desktop menu entries launch xterm w/o any options. I'm not sure that we need to cater to anyone's preferences in system.XWinrc; users should be customizing their ~/.XWinrc or ~/.Xdefaults to their tastes. Patch, minus the '-sb' addition, added to the queue. 38720 jon.turney 2009-10-08 20:56:31 +0000 (In reply to comment #13) > (In reply to comment #10) > > Created an attachment (id=4253) > > Tidy ups for system.Xwinrc > > > > Dropping this patch has dropped some tiding up in system.Xwinrc; here's a > > respun patch with just that in it... > > FWIW, the default fd.o desktop menu entries launch xterm w/o any options. I'm > not sure that we need to cater to anyone's preferences in system.XWinrc; users > should be customizing their ~/.XWinrc or ~/.Xdefaults to their tastes. > > Patch, minus the '-sb' addition, added to the queue. Yes, that's probably the right thing to do. Thanks. 38722 jon.turney 2009-10-08 21:25:07 +0000 (In reply to comment #12) > (In reply to comment #11) > > Oh, and xterm started from the tray menu doesn't seem to inherit the correct > > environment :-( > > Hmm.. mysterious: comparing the output of running 'C:\cygwin\bin\run bash -l -c > "env | sort >/tmp/env"' in a DOS shell, and "env | sort >/tmp/Xenv" from > system.Xwinrc, the only significant difference seems to be PS1... Learnt something new today: PS1 gets unset by non-interactive bash shells http://git.savannah.gnu.org/cgit/bash.git/tree/shell.c, around line 600 So setting in in /etc/profile and trying to inherit it everywhere isn't going to work :-( 38836 yselkowitz 2009-10-13 05:03:26 +0000 Patch shipped in 1.6.5-1; closing. 4031 2009-06-30 16:58:00 +0000 2009-06-30 16:58:57 +0000 Patch to use login bash shell for tray menu commands 0001-Execute-commands-using-a-login-bash-shell.patch text/plain 2175 jon.turney RnJvbSA1NjZmMmYwMjNlOGMzMGRlNzYyOWM3YjY1YTI4YzQ1YmRjMDEyMzc4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVFVSTkVZIDxqb24udHVybmV5QGRyb25lY29kZS5vcmcu dWs+CkRhdGU6IFR1ZSwgMzAgSnVuIDIwMDkgMTc6NDI6MzkgKzAxMDAKU3ViamVjdDogW1BBVENI XSBFeGVjdXRlIGNvbW1hbmRzIHVzaW5nIGEgbG9naW4gYmFzaCBzaGVsbAoKQ2hhbmdlIGV4ZWN1 dGluZyBjb21tYW5kcyBpbiBYV2lucmMgZnJvbSB1c2luZyAnL2Jpbi9zaCAtYycgdG8gdXNpbmcg Jy9iaW4vYmFzaCAtbCAtYycKVGlkeSB1cCBzeXN0ZW0uWHdpbnJjLCBnaXZlIHh0ZXJtIGEgc2Ny b2xsIGJhcgoKKGFmdGVyIGFwcGx5aW5nIHRoaXMgcGF0Y2gsIHNldHVwLmhpbnQgc2hvdWxkIGJl IGNoYW5nZWQgdG8gYWRkIGJhc2ggdG8gWCBzZXJ2ZXIncyBkZXBlbmRlbmNpZXMpCgoob3JnaW5h bGx5IGZyb20gYSBwYXRjaCBieSBLZW4gQnJvd24gPGticm93bkBjb3JuZWxsLmVkdT4pCi0tLQog aHcveHdpbi9fdXNyX1gxMVI2X2xpYl9YMTFfc3lzdGVtLlhXaW5yYyB8ICAgIDcgKysrKystLQog aHcveHdpbi93aW5wcmVmcy5jICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDUgKysrLS0KIDIg ZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2h3L3h3aW4vX3Vzcl9YMTFSNl9saWJfWDExX3N5c3RlbS5YV2lucmMgYi9ody94d2luL191 c3JfWDExUjZfbGliX1gxMV9zeXN0ZW0uWFdpbnJjCmluZGV4IDIzNjBiZmMuLjhlNzRkMGMgMTAw NjQ0Ci0tLSBhL2h3L3h3aW4vX3Vzcl9YMTFSNl9saWJfWDExX3N5c3RlbS5YV2lucmMKKysrIGIv aHcveHdpbi9fdXNyX1gxMVI2X2xpYl9YMTFfc3lzdGVtLlhXaW5yYwpAQCAtMTgsNiArMTgsOSBA QAogIyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeXiBUaGlzIGNvbW1hbmQgd2lsbCBo YXZlIGFueSAiJWRpc3BsYXklIgogIyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz dHJpbmcgcmVwbGFjZWQgd2l0aCB0aGUgcHJvcGVyIGRpc3BsYXkKICMgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdmFyaWFibGUgKGkuZS4gMTI3LjAuMC4xOjxkaXNwbGF5Pi4wKQor IyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoVGhpcyBzaG91bGQgb25seSByYXJl bHkgYmUgbmVlZGVkIGFzCisjICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRoZSBE SVNQTEFZIGVudmlyb25tZW50IHZhcmlhYmxlIGlzIGFsc28KKyMgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc2V0IGNvcnJlY3RseSkKICMgIG9yCTxNZW51IFRleHQ+CU1FTlUJPG5h bWUtb2Ytc29tZS1wcmlvci1kZWZpbmVkLW1lbnU+CiAjICBvcgk8TWVudSBUZXh0PglBTFdBWVNP TlRPUAogIyAgICAgICAgICAgICAgICAgICAgICAgICBeXiBTZXRzIHRoZSB3aW5kb3cgdG8gZGlz cGxheSBhYm92ZSBhbGwgb3RoZXJzCkBAIC03OSw4ICs4Miw4IEBACiAKIC8vIE1ha2Ugc29tZSBt ZW51cy4uLgogbWVudSBhcHBzIHsKLQl4dGVybQlleGVjCSJ4dGVybSIKLQkiRW1hY3MiCQlleGVj CSJlbWFjcyIKKwl4dGVybQlleGVjCSJ4dGVybSAtc2IiCisJIkVtYWNzIglleGVjCSJlbWFjcyIK IAlub3RlcGFkCWV4ZWMJbm90ZXBhZAogCXhsb2FkCWV4ZWMJInhsb2FkIC1kaXNwbGF5ICVkaXNw bGF5JSIgICMgQ29tbWVudAogfQpkaWZmIC0tZ2l0IGEvaHcveHdpbi93aW5wcmVmcy5jIGIvaHcv eHdpbi93aW5wcmVmcy5jCmluZGV4IGM1ZmQ3ZWIuLjZkNzA3M2QgMTAwNjQ0Ci0tLSBhL2h3L3h3 aW4vd2lucHJlZnMuYworKysgYi9ody94d2luL3dpbnByZWZzLmMKQEAgLTM3MSw4ICszNzEsOSBA QCBIYW5kbGVDdXN0b21XTV9DT01NQU5EICh1bnNpZ25lZCBsb25nIGh3bmRJbiwKIAkJICAgICAg LyogRGlzYXNzb2NpYXRlIGFueSBUVFlzICovCiAJCSAgICAgIHNldHNpZCgpOwogCi0JCSAgICAg IGV4ZWNsICgiL2Jpbi9zaCIsCi0JCQkgICAgICIvYmluL3NoIiwKKwkJICAgICAgZXhlY2wgKCIv YmluL2Jhc2giLAorCQkJICAgICAiL2Jpbi9iYXNoIiwKKwkJCSAgICAgIi1sIiwKIAkJCSAgICAg Ii1jIiwKIAkJCSAgICAgbS0+bWVudUl0ZW1bal0ucGFyYW0sCiAJCQkgICAgIE5VTEwpOwotLSAK MS42LjMuMgoK 4237 2009-09-30 17:22:00 +0000 2009-09-30 17:22:09 +0000 patch for ports/xorg/xinit xinit-bash-l-and-checkX.patch text/plain 1063 yselkowitz SW5kZXg6IHN0YXJ0eHdpbi5iYXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3RhcnR4d2luLmJhdAkocmV2aXNp b24gNzAyOSkKKysrIHN0YXJ0eHdpbi5iYXQJKHdvcmtpbmcgY29weSkKQEAgLTUxLDkgKzUxLDEy IEBACiAKIFJFTSBEZXNjcmlwdGlvbiBvZiBYV2luLXNwZWNpZmljIG9wdGlvbnMgaXMgaW4gWFdp bigxKSBtYW5wYWdlLgogCi0lUlVOJSBYV2luIC1tdWx0aXdpbmRvdyAtY2xpcGJvYXJkIC1zaWxl bnQtZHVwLWVycm9yCislUlVOJSBiYXNoIC1sIC1jICJYV2luIC1tdWx0aXdpbmRvdyAtY2xpcGJv YXJkIC1zaWxlbnQtZHVwLWVycm9yIgogCitSRU0gTWFrZSBzdXJlIFhXaW4gaXMgcmVhZHkgdG8g YWNjZXB0IGNvbm5lY3Rpb25zIGJlZm9yZSBwcm9jZWVkaW5nCiAKKyVSVU4lIGNoZWNrWCAtZCAl RElTUExBWSUgLXQgMTIKKwogUkVNIFN0YXJ0dXAgYW4geHRlcm0sIHVzaW5nIGJhc2ggYXMgdGhl IHNoZWxsLgogCiAlUlVOJSB4dGVybSAtZSAvdXNyL2Jpbi9iYXNoIC1sCkluZGV4OiBzdGFydHh3 aW4uc2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gc3RhcnR4d2luLnNoCShyZXZpc2lvbiA3MDI5KQorKysgc3Rh cnR4d2luLnNoCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotIyEgL2Jpbi9zaAorIyEg L2Jpbi9iYXNoIC1sCiBleHBvcnQgRElTUExBWT0xMjcuMC4wLjE6MC4wCiBleHBvcnQgUEFUSD0v dXNyL2JpbjoiJFBBVEgiCiAKQEAgLTI2LDcgKzI2LDEwIEBACiAKIFhXaW4gLW11bHRpd2luZG93 IC1jbGlwYm9hcmQgLXNpbGVudC1kdXAtZXJyb3IgJgogCisjIE1ha2Ugc3VyZSBYV2luIGlzIHJl YWR5IHRvIGFjY2VwdCBjb25uZWN0aW9ucyBiZWZvcmUgcHJvY2VlZGluZwogCitjaGVja1ggLWQg JERJU1BMQVkgLXQgMTIKKwogIyBTdGFydHVwIGFuIHh0ZXJtLCB1c2luZyBiYXNoIGFzIHRoZSBz aGVsbC4KIAogeHRlcm0gLWUgL3Vzci9iaW4vYmFzaCAtbCAmCg== 4253 2009-10-04 14:59:00 +0000 2009-10-04 14:59:21 +0000 Tidy ups for system.Xwinrc 0001-Tidy-up-system.Xwinrc-give-xterm-a-scroll-bar.patch text/plain 1457 jon.turney RnJvbSBjNDBlZWZhMzUwYTc4NTc5NTM5YjhiY2FmN2VjNmE3Yjc1MGM5MzZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVFVSTkVZIDxqb24udHVybmV5QGRyb25lY29kZS5vcmcu dWs+CkRhdGU6IFN1biwgNCBPY3QgMjAwOSAxNTo1NTo0MCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IFRpZHkgdXAgc3lzdGVtLlh3aW5yYywgZ2l2ZSB4dGVybSBhIHNjcm9sbCBiYXIKCgpTaWduZWQt b2ZmLWJ5OiBKb24gVFVSTkVZIDxqb24udHVybmV5QGRyb25lY29kZS5vcmcudWs+Ci0tLQogaHcv eHdpbi9fdXNyX1gxMVI2X2xpYl9YMTFfc3lzdGVtLlhXaW5yYyB8ICAgIDcgKysrKystLQogMSBm aWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvaHcveHdpbi9fdXNyX1gxMVI2X2xpYl9YMTFfc3lzdGVtLlhXaW5yYyBiL2h3L3h3aW4vX3Vz cl9YMTFSNl9saWJfWDExX3N5c3RlbS5YV2lucmMKaW5kZXggMjM2MGJmYy4uOGU3NGQwYyAxMDA2 NDQKLS0tIGEvaHcveHdpbi9fdXNyX1gxMVI2X2xpYl9YMTFfc3lzdGVtLlhXaW5yYworKysgYi9o dy94d2luL191c3JfWDExUjZfbGliX1gxMV9zeXN0ZW0uWFdpbnJjCkBAIC0xOCw2ICsxOCw5IEBA CiAjICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5eIFRoaXMgY29tbWFuZCB3aWxsIGhh dmUgYW55ICIlZGlzcGxheSUiCiAjICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 cmluZyByZXBsYWNlZCB3aXRoIHRoZSBwcm9wZXIgZGlzcGxheQogIyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB2YXJpYWJsZSAoaS5lLiAxMjcuMC4wLjE6PGRpc3BsYXk+LjApCisj ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChUaGlzIHNob3VsZCBvbmx5IHJhcmVs eSBiZSBuZWVkZWQgYXMKKyMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGhlIERJ U1BMQVkgZW52aXJvbm1lbnQgdmFyaWFibGUgaXMgYWxzbworIyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzZXQgY29ycmVjdGx5KQogIyAgb3IJPE1lbnUgVGV4dD4JTUVOVQk8bmFt ZS1vZi1zb21lLXByaW9yLWRlZmluZWQtbWVudT4KICMgIG9yCTxNZW51IFRleHQ+CUFMV0FZU09O VE9QCiAjICAgICAgICAgICAgICAgICAgICAgICAgIF5eIFNldHMgdGhlIHdpbmRvdyB0byBkaXNw bGF5IGFib3ZlIGFsbCBvdGhlcnMKQEAgLTc5LDggKzgyLDggQEAKIAogLy8gTWFrZSBzb21lIG1l bnVzLi4uCiBtZW51IGFwcHMgewotCXh0ZXJtCWV4ZWMJInh0ZXJtIgotCSJFbWFjcyIJCWV4ZWMJ ImVtYWNzIgorCXh0ZXJtCWV4ZWMJInh0ZXJtIC1zYiIKKwkiRW1hY3MiCWV4ZWMJImVtYWNzIgog CW5vdGVwYWQJZXhlYwlub3RlcGFkCiAJeGxvYWQJZXhlYwkieGxvYWQgLWRpc3BsYXkgJWRpc3Bs YXklIiAgIyBDb21tZW50CiB9Ci0tIAoxLjYuNC4yCgo=