Bug 17388 - Allow DW_FORM_GNU_addr_index in Fission skeleton CUs
Summary: Allow DW_FORM_GNU_addr_index in Fission skeleton CUs
Status: NEW
Alias: None
Product: gdb
Classification: Unclassified
Component: symtab (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-12 23:43 UTC by dje
Modified: 2014-09-12 23:43 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dje 2014-09-12 23:43:12 UTC
gdb currently flags an error for DW_FORM_GNU_addr_index appearing in Fission skeleton CUs.
There's no need for this restriction.

2014-09-12  Doug Evans  <dje@google.com>

        * dwarf2read.c (read_attribute_value): Allow DW_FORM_GNU_addr_index
        in Fission skeleton CUs.

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index be32309..430a945 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -16077,14 +16077,6 @@ read_attribute_value (const struct die_reader_specs *reader,
       info_ptr = read_attribute_value (reader, attr, form, info_ptr);
       break;
     case DW_FORM_GNU_addr_index:
-      if (reader->dwo_file == NULL)
-       {
-         /* For now flag a hard error.
-            Later we can turn this into a complaint.  */
-         error (_("Dwarf Error: %s found in non-DWO CU [in module %s]"),
-                dwarf_form_name (form),
-                bfd_get_filename (abfd));
-       }
       DW_ADDR (attr) = read_addr_index_from_leb128 (cu, info_ptr, &bytes_read);
       info_ptr += bytes_read;
       break;